git_cherrypick() leaving behind CHERRY_PICK_HEAD on success #7124
Description
Looking at this code:
libgit2/src/libgit2/cherrypick.c
Line 215 in 58d9363
.... it seems that cherrypick_state_cleanup() should be invoked on success, not on error, hence:
+ cherrypick_state_cleanup(repo); /// MUST do it here
goto done;
on_error:
- // cherrypick_state_cleanup(repo); // here it's inverted!, so drop it
done:
git_indexwriter_cleanup(&indexwriter);
....