CommitLog can be sealed because it has interface

dahlbyk · dahlbyk · commit 2e96549ccfdd · 2013-11-18T19:33:47.000-06:00
diff --git a/LibGit2Sharp.Tests/MockedRepositoryFixture.cs b/LibGit2Sharp.Tests/MockedRepositoryFixture.cs
@@ -29,7 +29,7 @@ public void CanCountCommitsWithConcreteRepository()
         [Fact]
         public void CanCountCommitsWithMockedRepository()
         {
-            var commitLog = Mock.Of<CommitLog>(cl => cl.GetEnumerator() == FakeCommitLog(17));
+            var commitLog = Mock.Of<IQueryableCommitLog>(cl => cl.GetEnumerator() == FakeCommitLog(17));
             var repo = Mock.Of<IRepository>(r => r.Commits == commitLog);
 
             var commitCounter = new CommitCounter(repo);
diff --git a/LibGit2Sharp/CommitLog.cs b/LibGit2Sharp/CommitLog.cs
@@ -11,17 +11,11 @@ namespace LibGit2Sharp
     /// <summary>
     /// A log of commits in a <see cref="Repository"/>
     /// </summary>
-    public class CommitLog : IQueryableCommitLog
+    public sealed class CommitLog : IQueryableCommitLog
     {
         private readonly Repository repo;
         private readonly CommitFilter queryFilter;
 
-        /// <summary>
-        /// Needed for mocking purposes.
-        /// </summary>
-        protected CommitLog()
-        { }
-
         /// <summary>
         /// Initializes a new instance of the <see cref="CommitLog"/> class.
         /// The commits will be enumerated according in reverse chronological order.
@@ -46,7 +40,7 @@ internal CommitLog(Repository repo, CommitFilter queryFilter)
         /// <summary>
         /// Gets the current sorting strategy applied when enumerating the log
         /// </summary>
-        public virtual CommitSortStrategies SortedBy
+        public CommitSortStrategies SortedBy
         {
             get { return queryFilter.SortBy; }
         }
@@ -57,7 +51,7 @@ public virtual CommitSortStrategies SortedBy
         /// Returns an enumerator that iterates through the log.
         /// </summary>
         /// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the log.</returns>
-        public virtual IEnumerator<Commit> GetEnumerator()
+        public IEnumerator<Commit> GetEnumerator()
         {
             return new CommitEnumerator(repo, queryFilter);
         }
@@ -78,7 +72,7 @@ IEnumerator IEnumerable.GetEnumerator()
         /// </summary>
         /// <param name="filter">The options used to control which commits will be returned.</param>
         /// <returns>A list of commits, ready to be enumerated.</returns>
-        public virtual ICommitLog QueryBy(CommitFilter filter)
+        public ICommitLog QueryBy(CommitFilter filter)
         {
             Ensure.ArgumentNotNull(filter, "filter");
             Ensure.ArgumentNotNull(filter.Since, "filter.Since");
@@ -93,7 +87,7 @@ public virtual ICommitLog QueryBy(CommitFilter filter)
         /// <param name="first">The first <see cref="Commit"/>.</param>
         /// <param name="second">The second <see cref="Commit"/>.</param>
         /// <returns>The common ancestor or null if none found.</returns>
-        public virtual Commit FindCommonAncestor(Commit first, Commit second)
+        public Commit FindCommonAncestor(Commit first, Commit second)
         {
             Ensure.ArgumentNotNull(first, "first");
             Ensure.ArgumentNotNull(second, "second");
@@ -108,7 +102,7 @@ public virtual Commit FindCommonAncestor(Commit first, Commit second)
         /// </summary>
         /// <param name="commits">The <see cref="Commit"/>s for which to find the common ancestor.</param>
         /// <returns>The common ancestor or null if none found.</returns>
-        public virtual Commit FindCommonAncestor(IEnumerable<Commit> commits)
+        public Commit FindCommonAncestor(IEnumerable<Commit> commits)
         {
             Ensure.ArgumentNotNull(commits, "commits");
 

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public void CanCountCommitsWithConcreteRepository()`
`29`	`29`	`[Fact]`
`30`	`30`	`public void CanCountCommitsWithMockedRepository()`
`31`	`31`	`{`
`32`		`- var commitLog = Mock.Of<CommitLog>(cl => cl.GetEnumerator() == FakeCommitLog(17));`
	`32`	`+ var commitLog = Mock.Of<IQueryableCommitLog>(cl => cl.GetEnumerator() == FakeCommitLog(17));`
`33`	`33`	`var repo = Mock.Of<IRepository>(r => r.Commits == commitLog);`
`34`	`34`
`35`	`35`	`var commitCounter = new CommitCounter(repo);`