meta fixture ensuring GetEnumerators are testable

half-ogre · half-ogre · commit 393b3bcdc91e · 2014-03-05T23:30:08.000-08:00
fix other non-virtual GetEnumerators

the simplest thing that works

simpler still

when in Rome…
diff --git a/LibGit2Sharp.Tests/MetaFixture.cs b/LibGit2Sharp.Tests/MetaFixture.cs
@@ -196,5 +196,30 @@ private static bool IsStatic(Type type)
         {
             return type.IsAbstract && type.IsSealed;
         }
+
+        // Related to https://github.com/libgit2/libgit2sharp/issues/644 and https://github.com/libgit2/libgit2sharp/issues/645
+        [Fact]
+        public void GetEnumeratorMethodsInLibGit2SharpMustBeVirtualForTestability()
+        {
+            var nonVirtualGetEnumeratorMethods = Assembly.GetAssembly(typeof(IRepository))
+                .GetExportedTypes()
+                .Where(t =>
+                    t.Namespace == typeof (IRepository).Namespace &&
+                    !t.IsSealed &&
+                    !t.IsAbstract &&
+                    t.GetInterfaces().Any(i => i.IsAssignableFrom(typeof(IEnumerable<>))))
+                .Select(t => t.GetMethod("GetEnumerator"))
+                .Where(m => 
+                    m.ReturnType.Name == "IEnumerator`1" &&
+                    (!m.IsVirtual || m.IsFinal))
+                .ToList();
+
+            foreach (var method in nonVirtualGetEnumeratorMethods)
+            {
+                Debug.WriteLine(String.Format("GetEnumerator in type '{0}' isn't virtual.", method.DeclaringType));
+            }
+
+            Assert.Empty(nonVirtualGetEnumeratorMethods);
+        }
     }
 }
diff --git a/LibGit2Sharp/BlameHunkCollection.cs b/LibGit2Sharp/BlameHunkCollection.cs
@@ -83,7 +83,7 @@ public virtual BlameHunk HunkForLine(int line)
         /// An <see cref="T:System.Collections.IEnumerator"/> object that can be used to iterate through the collection.
         /// </returns>
         /// <filterpriority>2</filterpriority>
-        public IEnumerator<BlameHunk> GetEnumerator()
+        public virtual IEnumerator<BlameHunk> GetEnumerator()
         {
             return hunks.GetEnumerator();
         }
diff --git a/LibGit2Sharp/ReflogCollection.cs b/LibGit2Sharp/ReflogCollection.cs
@@ -55,7 +55,7 @@ internal ReflogCollection(Repository repo, string canonicalName)
         /// </para>
         /// </summary>
         /// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the collection.</returns>
-        public IEnumerator<ReflogEntry> GetEnumerator()
+        public virtual IEnumerator<ReflogEntry> GetEnumerator()
         {
             var entries = new List<ReflogEntry>();
 
diff --git a/LibGit2Sharp/StashCollection.cs b/LibGit2Sharp/StashCollection.cs
@@ -40,7 +40,7 @@ internal StashCollection(Repository repo)
         /// </para>
         /// </summary>
         /// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the collection.</returns>
-        public IEnumerator<Stash> GetEnumerator()
+        public virtual IEnumerator<Stash> GetEnumerator()
         {
             return Proxy.git_stash_foreach(repo.Handle,
                 (index, message, commitId) => new Stash(repo, new ObjectId(commitId), index)).GetEnumerator();

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public virtual BlameHunk HunkForLine(int line)`
`83`	`83`	`/// An <see cref="T:System.Collections.IEnumerator"/> object that can be used to iterate through the collection.`
`84`	`84`	`/// </returns>`
`85`	`85`	`/// <filterpriority>2</filterpriority>`
`86`		`- public IEnumerator<BlameHunk> GetEnumerator()`
	`86`	`+ public virtual IEnumerator<BlameHunk> GetEnumerator()`
`87`	`87`	`{`
`88`	`88`	`return hunks.GetEnumerator();`
`89`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ internal ReflogCollection(Repository repo, string canonicalName)`
`55`	`55`	`/// </para>`
`56`	`56`	`/// </summary>`
`57`	`57`	`/// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the collection.</returns>`
`58`		`- public IEnumerator<ReflogEntry> GetEnumerator()`
	`58`	`+ public virtual IEnumerator<ReflogEntry> GetEnumerator()`
`59`	`59`	`{`
`60`	`60`	`var entries = new List<ReflogEntry>();`
`61`	`61`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ internal StashCollection(Repository repo)`
`40`	`40`	`/// </para>`
`41`	`41`	`/// </summary>`
`42`	`42`	`/// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the collection.</returns>`
`43`		`- public IEnumerator<Stash> GetEnumerator()`
	`43`	`+ public virtual IEnumerator<Stash> GetEnumerator()`
`44`	`44`	`{`
`45`	`45`	`return Proxy.git_stash_foreach(repo.Handle,`
`46`	`46`	`(index, message, commitId) => new Stash(repo, new ObjectId(commitId), index)).GetEnumerator();`