Remove property setters since options are initialized

bording · bording · commit 747bfc62fff7 · 2023-11-26T21:31:29.000-05:00
diff --git a/LibGit2Sharp.Tests/CloneFixture.cs b/LibGit2Sharp.Tests/CloneFixture.cs
@@ -567,10 +567,8 @@ public void CannotCloneWithForbiddenCustomHeaders()
             const string url = "https://github.com/libgit2/TestGitRepository";
 
             const string knownHeader = "User-Agent: mygit-201";
-            var cloneOptions = new CloneOptions()
-            {
-                FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
-            };
+            var cloneOptions = new CloneOptions();
+            cloneOptions.FetchOptions.CustomHeaders = new string[] { knownHeader };
 
             Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions));
         }
@@ -583,10 +581,8 @@ public void CannotCloneWithMalformedCustomHeaders()
             const string url = "https://github.com/libgit2/TestGitRepository";
 
             const string knownHeader = "hello world";
-            var cloneOptions = new CloneOptions()
-            {
-                FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
-            };
+            var cloneOptions = new CloneOptions();
+            cloneOptions.FetchOptions.CustomHeaders = new string[] { knownHeader };
 
             Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions));
         }
@@ -599,10 +595,8 @@ public void CanCloneWithCustomHeaders()
             const string url = "https://github.com/libgit2/TestGitRepository";
 
             const string knownHeader = "X-Hello: world";
-            var cloneOptions = new CloneOptions()
-            {
-                FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
-            };
+            var cloneOptions = new CloneOptions();
+            cloneOptions.FetchOptions.CustomHeaders = new string[] { knownHeader };
 
             var clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, cloneOptions);
             Assert.True(Directory.Exists(clonedRepoPath));
diff --git a/LibGit2Sharp/CloneOptions.cs b/LibGit2Sharp/CloneOptions.cs
@@ -46,7 +46,7 @@ public CloneOptions()
         /// <summary>
         /// Gets or sets the fetch options.
         /// </summary>
-        public FetchOptions FetchOptions { get; set; } = new();
+        public FetchOptions FetchOptions { get; } = new();
 
         #region IConvertableToGitCheckoutOpts
 
diff --git a/LibGit2Sharp/FetchOptionsBase.cs b/LibGit2Sharp/FetchOptionsBase.cs
@@ -49,6 +49,6 @@ internal FetchOptionsBase()
         /// </summary>
         public RepositoryOperationCompleted RepositoryOperationCompleted { get; set; }
 
-        public ProxyOptions ProxyOptions { get; set; } = new();
+        public ProxyOptions ProxyOptions { get; } = new();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,6 @@ internal FetchOptionsBase()`
`49`	`49`	`/// </summary>`
`50`	`50`	`public RepositoryOperationCompleted RepositoryOperationCompleted { get; set; }`
`51`	`51`
`52`		`- public ProxyOptions ProxyOptions { get; set; } = new();`
	`52`	`+ public ProxyOptions ProxyOptions { get; } = new();`
`53`	`53`	`}`
`54`	`54`	`}`