Introduce Identity type

nulltoken · nulltoken · commit 964943bf9bed · 2015-03-17T19:56:17.000+01:00
diff --git a/LibGit2Sharp.Tests/TestHelpers/Constants.cs b/LibGit2Sharp.Tests/TestHelpers/Constants.cs
@@ -6,7 +6,8 @@ public static class Constants
     {
         public const string TemporaryReposPath = "TestRepos";
         public const string UnknownSha = "deadbeefdeadbeefdeadbeefdeadbeefdeadbeef";
-        public static readonly Signature Signature = new Signature("A. U. Thor", "thor@valhalla.asgard.com", new DateTimeOffset(2011, 06, 16, 10, 58, 27, TimeSpan.FromHours(2)));
+        public static readonly Identity Identity = new Identity("A. U. Thor", "thor@valhalla.asgard.com");
+        public static readonly Signature Signature = new Signature(Identity, new DateTimeOffset(2011, 06, 16, 10, 58, 27, TimeSpan.FromHours(2)));
 
         // Populate these to turn on live credential tests:  set the
         // PrivateRepoUrl to the URL of a repository that requires
diff --git a/LibGit2Sharp/Identity.cs b/LibGit2Sharp/Identity.cs
@@ -0,0 +1,45 @@
+﻿using LibGit2Sharp.Core;
+
+namespace LibGit2Sharp
+{
+    /// <summary>
+    /// Represents the identity used when writing reflog entries.
+    /// </summary>
+    public sealed class Identity
+    {
+        private readonly string _name;
+        private readonly string _email;
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="Identity"/> class.
+        /// </summary>
+        /// <param name="name">The name.</param>
+        /// <param name="email">The email.</param>
+        public Identity(string name, string email)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(name, "name");
+            Ensure.ArgumentNotNullOrEmptyString(email, "email");
+            Ensure.ArgumentDoesNotContainZeroByte(name, "name");
+            Ensure.ArgumentDoesNotContainZeroByte(name, "email");
+
+            _name = name;
+            _email = email;
+        }
+
+        /// <summary>
+        /// Gets the email.
+        /// </summary>
+        public string Email
+        {
+            get { return _email; }
+        }
+
+        /// <summary>
+        /// Gets the name.
+        /// </summary>
+        public string Name
+        {
+            get { return _name; }
+        }
+    }
+}
diff --git a/LibGit2Sharp/LibGit2Sharp.csproj b/LibGit2Sharp/LibGit2Sharp.csproj
@@ -80,6 +80,7 @@
     <Compile Include="EntryExistsException.cs" />
     <Compile Include="FetchOptionsBase.cs" />
     <Compile Include="IBelongToARepository.cs" />
+    <Compile Include="Identity.cs" />
     <Compile Include="IndexNameEntryCollection.cs" />
     <Compile Include="ContentChangeStats.cs" />
     <Compile Include="BuiltInFeatures.cs" />
diff --git a/LibGit2Sharp/Signature.cs b/LibGit2Sharp/Signature.cs
@@ -44,6 +44,20 @@ public Signature(string name, string email, DateTimeOffset when)
             this.when = when;
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="Signature"/> class.
+        /// </summary>
+        /// <param name="identity">The identity.</param>
+        /// <param name="when">The when.</param>
+        public Signature(Identity identity, DateTimeOffset when)
+        {
+            Ensure.ArgumentNotNull(identity, "identity");
+
+            this.name = identity.Name;
+            this.email = identity.Email;
+            this.when = when;
+        }
+
         internal SignatureSafeHandle BuildHandle()
         {
             return Proxy.git_signature_new(name, email, when);

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,8 @@ public static class Constants`
`6`	`6`	`{`
`7`	`7`	`public const string TemporaryReposPath = "TestRepos";`
`8`	`8`	`public const string UnknownSha = "deadbeefdeadbeefdeadbeefdeadbeefdeadbeef";`
`9`		`- public static readonly Signature Signature = new Signature("A. U. Thor", "thor@valhalla.asgard.com", new DateTimeOffset(2011, 06, 16, 10, 58, 27, TimeSpan.FromHours(2)));`
	`9`	`+ public static readonly Identity Identity = new Identity("A. U. Thor", "thor@valhalla.asgard.com");`
	`10`	`+ public static readonly Signature Signature = new Signature(Identity, new DateTimeOffset(2011, 06, 16, 10, 58, 27, TimeSpan.FromHours(2)));`
`10`	`11`
`11`	`12`	`// Populate these to turn on live credential tests: set the`
`12`	`13`	`// PrivateRepoUrl to the URL of a repository that requires`