tests: Catch exceptions by const ref.

murraycu · murraycu · commit 158595451544 · 2016-11-23T10:27:27.000+01:00
Noticed by cppcheck.
diff --git a/tests/test_exception_catch.cc b/tests/test_exception_catch.cc
@@ -53,7 +53,7 @@ struct my_catch
     {
       throw;
     }
-    catch (std::range_error e) // catch what types we know
+    catch (const std::range_error& e) // catch what types we know
     {
       result_stream << "caught " << e.what();
     }
@@ -70,7 +70,7 @@ struct my_catch_void
     {
       throw;
     }
-    catch (std::range_error e) // catch what types we know
+    catch (const std::range_error& e) // catch what types we know
     {
       result_stream << "caught " << e.what();
     }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ struct my_catch`
`53`	`53`	`{`
`54`	`54`	`throw;`
`55`	`55`	`}`
`56`		`- catch (std::range_error e) // catch what types we know`
	`56`	`+ catch (const std::range_error& e) // catch what types we know`
`57`	`57`	`{`
`58`	`58`	`result_stream << "caught " << e.what();`
`59`	`59`	`}`
`@@ -70,7 +70,7 @@ struct my_catch_void`
`70`	`70`	`{`
`71`	`71`	`throw;`
`72`	`72`	`}`
`73`		`- catch (std::range_error e) // catch what types we know`
	`73`	`+ catch (const std::range_error& e) // catch what types we know`
`74`	`74`	`{`
`75`	`75`	`result_stream << "caught " << e.what();`
`76`	`76`	`}`