Skip to content

Commit 1eed1d0

Browse files
fanc999-1kjellahl
authored andcommitted
meson: Ensure symbols are exported on MSVC builds
Make sure the correct build macros are specified when building libsigc++, so that: -The symbols are properly exported -We do not break builds as a result of unecesary warnings
1 parent 2f87f7f commit 1eed1d0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

sigc++/meson.build

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,13 @@ src_untracked_sigcxx = project_source_root / untracked_sigcxx
9292

9393
handle_built_files = project_source_root / 'tools' / 'handle-built-files.py'
9494

95+
extra_sigc_cppflags = []
96+
97+
# Make sure we are exporting the symbols from the DLL
98+
if is_msvc
99+
extra_sigc_cppflags += ['-DSIGC_BUILD', '-D_WINDLL']
100+
endif
101+
95102
if maintainer_mode
96103

97104
# Maintainer mode. Generate .h and .cc files from .m4 files in macros/ directories.
@@ -152,6 +159,7 @@ if maintainer_mode
152159
sigcxx_library = library(sigcxx_pcname,
153160
source_cc_files, built_cc_file_targets, built_h_file_targets,
154161
version: sigcxx_libversion,
162+
cpp_args: extra_sigc_cppflags,
155163
include_directories: extra_include_dirs,
156164
dependencies: sigcxx_build_dep,
157165
install: true,
@@ -193,6 +201,7 @@ else # not maintainer_mode
193201
sigcxx_library = library(sigcxx_pcname,
194202
source_cc_files, untracked_built_cc_files,
195203
version: sigcxx_libversion,
204+
cpp_args: extra_sigc_cppflags,
196205
include_directories: extra_include_dirs,
197206
dependencies: sigcxx_build_dep,
198207
install: true,

0 commit comments

Comments
 (0)