tests: Make single argument constructors explicit.

murraycu · murraycu · commit 414d9f47f3c7 · 2016-04-22T10:51:32.000+02:00
Found by the google-explicit-constructor clang-tidy check.
diff --git a/tests/test_bind.cc b/tests/test_bind.cc
@@ -68,7 +68,7 @@ egon(std::string& str)
 
 struct book : public sigc::trackable
 {
-  book(const std::string& name) : name_(name) {}
+  explicit book(const std::string& name) : name_(name) {}
 
   // non-copyable:
   book(const book&) = delete;
diff --git a/tests/test_bind_ref.cc b/tests/test_bind_ref.cc
@@ -16,7 +16,7 @@ std::ostringstream result_stream;
 class Param : public sigc::trackable
 {
 public:
-  Param(const std::string& name) : name_(name) {}
+  explicit Param(const std::string& name) : name_(name) {}
 
   // non-copyable,
   // so it can only be used with sigc::bind() via sigc::ref()
diff --git a/tests/test_bind_refptr.cc b/tests/test_bind_refptr.cc
@@ -86,7 +86,7 @@ class RefPtr
    * Increments the reference count.
    */
   template <typename T_CastFrom>
-  inline RefPtr(const RefPtr<T_CastFrom>& src);
+  inline explicit RefPtr(const RefPtr<T_CastFrom>& src);
 
   /** Swap the contents of two RefPtr<>.
    * This method swaps the internal pointers to T_CppObject.  This can be
diff --git a/tests/test_bind_return.cc b/tests/test_bind_return.cc
@@ -27,7 +27,7 @@ struct foo
 
 struct bar : public sigc::trackable
 {
-  bar(int i = 0) : i_(i) {}
+  explicit bar(int i = 0) : i_(i) {}
   operator int() { return i_; }
   int i_;
 };
diff --git a/tests/test_track_obj.cc b/tests/test_track_obj.cc
@@ -62,7 +62,7 @@ class Functor1
 public:
   using result_type = std::string;
 
-  Functor1(const bar_group4& bar) : bar_(bar) {}
+  explicit Functor1(const bar_group4& bar) : bar_(bar) {}
 
   std::string operator()(int i) { return (i < 0) ? "negative" : ((i > 0) ? "positive" : "zero"); }
 
diff --git a/tests/test_visit_each.cc b/tests/test_visit_each.cc
@@ -59,7 +59,7 @@ namespace
 class MyClass1 : public sigc::trackable
 {
 public:
-  MyClass1(const std::string& str) : s(str) {}
+  explicit MyClass1(const std::string& str) : s(str) {}
 
   void execute(int i) { result_stream << s << i; }
 private:
@@ -69,7 +69,7 @@ class MyClass1 : public sigc::trackable
 class MyClass2 : public ns_ext::NsExtClass, public sigc::trackable
 {
 public:
-  MyClass2(const std::string& str) : s(str) {}
+  explicit MyClass2(const std::string& str) : s(str) {}
 
   void execute(int i) { result_stream << s << i; }
 private:

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ egon(std::string& str)`
`68`	`68`
`69`	`69`	`struct book : public sigc::trackable`
`70`	`70`	`{`
`71`		`- book(const std::string& name) : name_(name) {}`
	`71`	`+ explicit book(const std::string& name) : name_(name) {}`
`72`	`72`
`73`	`73`	`// non-copyable:`
`74`	`74`	`book(const book&) = delete;`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ std::ostringstream result_stream;`
`16`	`16`	`class Param : public sigc::trackable`
`17`	`17`	`{`
`18`	`18`	`public:`
`19`		`- Param(const std::string& name) : name_(name) {}`
	`19`	`+ explicit Param(const std::string& name) : name_(name) {}`
`20`	`20`
`21`	`21`	`// non-copyable,`
`22`	`22`	`// so it can only be used with sigc::bind() via sigc::ref()`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ struct foo`
`27`	`27`
`28`	`28`	`struct bar : public sigc::trackable`
`29`	`29`	`{`
`30`		`- bar(int i = 0) : i_(i) {}`
	`30`	`+ explicit bar(int i = 0) : i_(i) {}`
`31`	`31`	`operator int() { return i_; }`
`32`	`32`	`int i_;`
`33`	`33`	`};`