trackable: Use emplace_back() instead of push_back().

murraycu · murraycu · commit 562d2095e036 · 2017-07-21T08:20:58.000+02:00
Found by clang-tidy.
diff --git a/sigc++/trackable.cc b/sigc++/trackable.cc
@@ -119,7 +119,7 @@ trackable_callback_list::add_callback(notifiable* data, func_destroy_notify func
   // I'd consider this a serious application bug, since the app is likely to segfault.
   // But then, how should we handle it? Throw an exception? Martin.
   if (!clearing_)
-    callbacks_.push_back(trackable_callback(data, func));
+    callbacks_.emplace_back(trackable_callback(data, func));
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ trackable_callback_list::add_callback(notifiable* data, func_destroy_notify func`
`119`	`119`	`// I'd consider this a serious application bug, since the app is likely to segfault.`
`120`	`120`	`// But then, how should we handle it? Throw an exception? Martin.`
`121`	`121`	`if (!clearing_)`
`122`		`- callbacks_.push_back(trackable_callback(data, func));`
	`122`	`+ callbacks_.emplace_back(trackable_callback(data, func));`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`void`