trackable: Don't bother checking for null before using delete.

murraycu · murraycu · commit 7902df0362d9 · 2017-07-21T08:20:58.000+02:00
Because deleting null is allowed.
Noticed by clang-tidy.
diff --git a/sigc++/trackable.cc b/sigc++/trackable.cc
@@ -83,9 +83,7 @@ trackable::remove_destroy_notify_callback(notifiable* data) const
 void
 trackable::notify_callbacks()
 {
-  if (callback_list_)
-    delete callback_list_; // This invokes all of the callbacks.
-
+  delete callback_list_; // This invokes all of the callbacks.
   callback_list_ = nullptr;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,7 @@ trackable::remove_destroy_notify_callback(notifiable* data) const`
`83`	`83`	`void`
`84`	`84`	`trackable::notify_callbacks()`
`85`	`85`	`{`
`86`		`- if (callback_list_)`
`87`		`- delete callback_list_; // This invokes all of the callbacks.`
`88`		`-`
	`86`	`+ delete callback_list_; // This invokes all of the callbacks.`
`89`	`87`	`callback_list_ = nullptr;`
`90`	`88`	`}`
`91`	`89`