signal_base: Do not derive from trackable.

murraycu · murraycu · commit a3e2fe669821 · 2016-04-28T12:55:13.000+02:00
Because we don't seem to actually use the trackable API when using
these objects. There was a call to notify_callbacks(), but that
cannot have done anything, because nothing registers any callbacks
with the base trackable, and now cannot possibly register any
callbacks, because it's no longer a trackable.
diff --git a/sigc++/signal_base.cc b/sigc++/signal_base.cc
@@ -204,11 +204,11 @@ signal_base::signal_base() noexcept
 {
 }
 
-signal_base::signal_base(const signal_base& src) noexcept : trackable(), impl_(src.impl())
+signal_base::signal_base(const signal_base& src) noexcept : impl_(src.impl())
 {
 }
 
-signal_base::signal_base(signal_base&& src) : trackable(std::move(src)), impl_(std::move(src.impl_))
+signal_base::signal_base(signal_base&& src) : impl_(std::move(src.impl_))
 {
   src.impl_ = nullptr;
 }
@@ -296,7 +296,6 @@ signal_base::operator=(signal_base&& src)
   if (src.impl_ == impl_)
     return *this;
 
-  src.notify_callbacks();
   impl_ = src.impl_;
   src.impl_ = nullptr;
 
diff --git a/sigc++/signal_base.h b/sigc++/signal_base.h
@@ -289,7 +289,7 @@ struct SIGC_API signal_impl_holder
  *
  * @ingroup signal
  */
-struct SIGC_API signal_base : public trackable
+struct SIGC_API signal_base
 {
   using size_type = std::size_t;
 

Original file line number	Diff line number	Diff line change
`@@ -204,11 +204,11 @@ signal_base::signal_base() noexcept`
`204`	`204`	`{`
`205`	`205`	`}`
`206`	`206`
`207`		`-signal_base::signal_base(const signal_base& src) noexcept : trackable(), impl_(src.impl())`
	`207`	`+signal_base::signal_base(const signal_base& src) noexcept : impl_(src.impl())`
`208`	`208`	`{`
`209`	`209`	`}`
`210`	`210`
`211`		`-signal_base::signal_base(signal_base&& src) : trackable(std::move(src)), impl_(std::move(src.impl_))`
	`211`	`+signal_base::signal_base(signal_base&& src) : impl_(std::move(src.impl_))`
`212`	`212`	`{`
`213`	`213`	`src.impl_ = nullptr;`
`214`	`214`	`}`
`@@ -296,7 +296,6 @@ signal_base::operator=(signal_base&& src)`
`296`	`296`	`if (src.impl_ == impl_)`
`297`	`297`	`return *this;`
`298`	`298`
`299`		`- src.notify_callbacks();`
`300`	`299`	`impl_ = src.impl_;`
`301`	`300`	`src.impl_ = nullptr;`
`302`	`301`
Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ struct SIGC_API signal_impl_holder`
`289`	`289`	`*`
`290`	`290`	`* @ingroup signal`
`291`	`291`	`*/`
`292`		`-struct SIGC_API signal_base : public trackable`
	`292`	`+struct SIGC_API signal_base`
`293`	`293`	`{`
`294`	`294`	`using size_type = std::size_t;`
`295`	`295`