trackable, slot, signal: Remove noexcept specifications

Kjell Ahlstedt · Kjell Ahlstedt · commit b53b58b7816c · 2015-11-08T10:03:28.000+01:00
* sigc++/functors/macros/slot.h.m4:
* sigc++/functors/slot_base.[h|cc]:
* sigc++/signal_base.[h|cc]:
* sigc++/trackable.[h|cc]: Remove noexcept from the move operators.
Bug #756484.
diff --git a/sigc++/functors/macros/slot.h.m4 b/sigc++/functors/macros/slot.h.m4
@@ -91,7 +91,7 @@ FOR(1, $1,[
    * If @p src is connected to a parent (e.g. a signal), it is copied, not moved.
    * @param src The existing slot to move or copy.
    */
-  slot$1(slot$1&& src) noexcept
+  slot$1(slot$1&& src)
     : slot_base(std::move(src))
     {}
 
@@ -110,7 +110,7 @@ FOR(1, $1,[
    * @param src The slot from which to move or copy.
    * @return @p this.
    */
-  slot$1& operator=(slot$1&& src) noexcept
+  slot$1& operator=(slot$1&& src)
   {
     slot_base::operator=(std::move(src));
     return *this;
diff --git a/sigc++/functors/slot_base.cc b/sigc++/functors/slot_base.cc
@@ -124,7 +124,7 @@ slot_base::slot_base(const slot_base& src)
   }
 }
 
-slot_base::slot_base(slot_base&& src) noexcept
+slot_base::slot_base(slot_base&& src)
 : rep_(nullptr),
   blocked_(src.blocked_)
 {
@@ -219,7 +219,7 @@ slot_base& slot_base::operator=(const slot_base& src)
   return *this;
 }
 
-slot_base& slot_base::operator=(slot_base&& src) noexcept
+slot_base& slot_base::operator=(slot_base&& src)
 {
   if (src.rep_ == rep_)
   {
diff --git a/sigc++/functors/slot_base.h b/sigc++/functors/slot_base.h
@@ -244,6 +244,10 @@ class SIGC_API slot_base : public functor_base
 {
   typedef internal::slot_rep rep_type;
 
+  // Move operations are not declared noexcept because
+  // 1. they may copy instead of move
+  // 2. when they don't copy, they call src.rep_->notify_callbacks(), which
+  //    may throw an exception.
 public:
   /// Constructs an empty slot.
   slot_base();
@@ -262,7 +266,7 @@ class SIGC_API slot_base : public functor_base
    * If @p src is connected to a parent (e.g. a signal), it is copied, not moved.
    * @param src The existing slot to move or copy.
    */
-  slot_base(slot_base&& src) noexcept;
+  slot_base(slot_base&& src);
 
   ~slot_base();
 
@@ -344,7 +348,7 @@ class SIGC_API slot_base : public functor_base
    * @param src The slot from which to move or copy.
    * @return @p this.
    */
-  slot_base& operator=(slot_base&& src) noexcept;
+  slot_base& operator=(slot_base&& src);
 
 public: // public to avoid template friend declarations
   /** Typed slot_rep object that contains a functor. */
diff --git a/sigc++/signal_base.cc b/sigc++/signal_base.cc
@@ -167,7 +167,7 @@ signal_base::signal_base(const signal_base& src)
   impl_->reference();
 }
 
-signal_base::signal_base(signal_base&& src) noexcept
+signal_base::signal_base(signal_base&& src)
 : trackable(std::move(src)),
   impl_(std::move(src.impl_))
 {
@@ -248,7 +248,7 @@ signal_base& signal_base::operator=(const signal_base& src)
   return *this;
 }
 
-signal_base& signal_base::operator=(signal_base&& src) noexcept
+signal_base& signal_base::operator=(signal_base&& src)
 {
   if (src.impl_ == impl_) return *this;
 
diff --git a/sigc++/signal_base.h b/sigc++/signal_base.h
@@ -290,13 +290,13 @@ struct SIGC_API signal_base : public trackable
 
   signal_base(const signal_base& src);
 
-  signal_base(signal_base&& src) noexcept;
+  signal_base(signal_base&& src);
 
   ~signal_base();
 
   signal_base& operator=(const signal_base& src);
 
-  signal_base& operator=(signal_base&& src) noexcept;
+  signal_base& operator=(signal_base&& src);
 
   /** Returns whether the list of slots is empty.
    * @return @p true if the list of slots is empty.
diff --git a/sigc++/trackable.cc b/sigc++/trackable.cc
@@ -43,7 +43,7 @@ trackable::trackable(const trackable& /*src*/)
 //
 // If trackable's move constructor is modified, check if Glib::Object's
 // move constructor should be modified similarly.
-trackable::trackable(trackable&& src) noexcept
+trackable::trackable(trackable&& src)
 : callback_list_(nullptr)
 {
   src.notify_callbacks();
@@ -57,7 +57,7 @@ trackable& trackable::operator=(const trackable& src)
   return *this;
 }
 
-trackable& trackable::operator=(trackable&& src) noexcept
+trackable& trackable::operator=(trackable&& src)
 {
   if(this != &src)
   {
diff --git a/sigc++/trackable.h b/sigc++/trackable.h
@@ -108,15 +108,20 @@ struct SIGC_API trackable_callback_list
  */
 struct SIGC_API trackable
 {
+  // Concerning noexcept specifications:
+  // libsigc++ does not have complete control of what happens when notify_callbacks()
+  // is called. It may throw an exception. A method that calls notify_callbacks()
+  // shall not be declared noexcept.
+
   trackable();
 
   trackable(const trackable& src);
 
-  trackable(trackable&& src) noexcept;
+  trackable(trackable&& src);
 
   trackable& operator=(const trackable& src);
 
-  trackable& operator=(trackable&& src) noexcept;
+  trackable& operator=(trackable&& src);
 
   ~trackable();
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ slot_base::slot_base(const slot_base& src)`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`
`127`		`-slot_base::slot_base(slot_base&& src) noexcept`
	`127`	`+slot_base::slot_base(slot_base&& src)`
`128`	`128`	`: rep_(nullptr),`
`129`	`129`	`blocked_(src.blocked_)`
`130`	`130`	`{`
`@@ -219,7 +219,7 @@ slot_base& slot_base::operator=(const slot_base& src)`
`219`	`219`	`return *this;`
`220`	`220`	`}`
`221`	`221`
`222`		`-slot_base& slot_base::operator=(slot_base&& src) noexcept`
	`222`	`+slot_base& slot_base::operator=(slot_base&& src)`
`223`	`223`	`{`
`224`	`224`	`if (src.rep_ == rep_)`
`225`	`225`	`{`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ signal_base::signal_base(const signal_base& src)`
`167`	`167`	`impl_->reference();`
`168`	`168`	`}`
`169`	`169`
`170`		`-signal_base::signal_base(signal_base&& src) noexcept`
	`170`	`+signal_base::signal_base(signal_base&& src)`
`171`	`171`	`: trackable(std::move(src)),`
`172`	`172`	`impl_(std::move(src.impl_))`
`173`	`173`	`{`
`@@ -248,7 +248,7 @@ signal_base& signal_base::operator=(const signal_base& src)`
`248`	`248`	`return *this;`
`249`	`249`	`}`
`250`	`250`
`251`		`-signal_base& signal_base::operator=(signal_base&& src) noexcept`
	`251`	`+signal_base& signal_base::operator=(signal_base&& src)`
`252`	`252`	`{`
`253`	`253`	`if (src.impl_ == impl_) return *this;`
`254`	`254`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ trackable::trackable(const trackable& /src/)`
`43`	`43`	`//`
`44`	`44`	`// If trackable's move constructor is modified, check if Glib::Object's`
`45`	`45`	`// move constructor should be modified similarly.`
`46`		`-trackable::trackable(trackable&& src) noexcept`
	`46`	`+trackable::trackable(trackable&& src)`
`47`	`47`	`: callback_list_(nullptr)`
`48`	`48`	`{`
`49`	`49`	`src.notify_callbacks();`
`@@ -57,7 +57,7 @@ trackable& trackable::operator=(const trackable& src)`
`57`	`57`	`return *this;`
`58`	`58`	`}`
`59`	`59`
`60`		`-trackable& trackable::operator=(trackable&& src) noexcept`
	`60`	`+trackable& trackable::operator=(trackable&& src)`
`61`	`61`	`{`
`62`	`62`	`if(this != &src)`
`63`	`63`	`{`