signal_impl: Rename notify_self_and_iter_invalidated().

murraycu · murraycu · commit c1c45be4c10e · 2016-04-21T19:56:00.000+02:00
To notify_self_and_iter_of_invalidated_slot(), to make it clear both
what is being notified, and what is being invalidated.
diff --git a/sigc++/signal_base.cc b/sigc++/signal_base.cc
@@ -143,7 +143,7 @@ void
 signal_impl::add_notification_to_iter(const signal_impl::iterator_type& iter)
 {
   auto si = new self_and_iter(this, iter);
-  iter->set_parent(si, &signal_impl::notify_self_and_iter_invalidated);
+  iter->set_parent(si, &signal_impl::notify_self_and_iter_of_invalidated_slot);
 }
 
 signal_impl::iterator_type
@@ -183,7 +183,7 @@ signal_impl::sweep()
 
 // static
 void
-signal_impl::notify_self_and_iter_invalidated(notifiable* d)
+signal_impl::notify_self_and_iter_of_invalidated_slot(notifiable* d)
 {
   std::unique_ptr<self_and_iter> si(static_cast<self_and_iter*>(d));
 
diff --git a/sigc++/signal_base.h b/sigc++/signal_base.h
@@ -175,7 +175,7 @@ struct SIGC_API signal_impl : public notifiable
    * erase() to sweep() when the signal is being emitted.
    * @param d A local structure, created in insert().
    */
-  static void notify_self_and_iter_invalidated(notifiable* d);
+  static void notify_self_and_iter_of_invalidated_slot(notifiable* d);
 
   void add_notification_to_iter(const signal_impl::iterator_type& iter);
 

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ void`
`143`	`143`	`signal_impl::add_notification_to_iter(const signal_impl::iterator_type& iter)`
`144`	`144`	`{`
`145`	`145`	`auto si = new self_and_iter(this, iter);`
`146`		`- iter->set_parent(si, &signal_impl::notify_self_and_iter_invalidated);`
	`146`	`+ iter->set_parent(si, &signal_impl::notify_self_and_iter_of_invalidated_slot);`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`signal_impl::iterator_type`
`@@ -183,7 +183,7 @@ signal_impl::sweep()`
`183`	`183`
`184`	`184`	`// static`
`185`	`185`	`void`
`186`		`-signal_impl::notify_self_and_iter_invalidated(notifiable* d)`
	`186`	`+signal_impl::notify_self_and_iter_of_invalidated_slot(notifiable* d)`
`187`	`187`	`{`
`188`	`188`	`std::unique_ptr<self_and_iter> si(static_cast<self_and_iter*>(d));`
`189`	`189`