Skip to content

Remove [[no_discard]] from constructors #102

Closed
@vadimgrn

Description

@vadimgrn

scoped_connection.h has several constructors that are decorated with [[no_discard]]. It makes no sense for constructors and should be removed. Compilers generate warnings for them. If warnings are treated as errors, it will break a build.

P.S. You overuse [[no_discard]]. Use it only for functions that allocate memory or resources that must be released.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions