vips_sharpen() requires VIPS_FORMAT_SHORT, but why does it not apply such cast itself? #4147
Closed
VivitionDeveloper
started this conversation in
General
Replies: 2 comments 1 reply
-
Hi again, you're right, |
Beta Was this translation helpful? Give feedback.
0 replies
-
.... I pushed the change to master. Thanks for reporting this. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I just discovered that vips_sharpen requires band format VIPS_FORMAT_SHORT, but why does vips_sharpen itself not perform a conversion?
In my case, the saturation was adjusted by adjusting the AB values of LABS. As that correction was applied by VImage.linear({1, 1.1, 1.1}, 0) then the resulting LABS image became floats (I guess). When the sharpen was applied, an error was raised:
I found this check came from:
libvips/libvips/convolution/sharpen.c
Line 203 in 12cf4bd
My pseudo code is:
I can of course apply a cast, but why does vips_sharpen itself not apply a cast for an image that is already in LABS color space?
Beta Was this translation helpful? Give feedback.
All reactions