Skip to content

Regression with fallback ICC profile (master) #1286

Closed
@kleisauke

Description

@kleisauke

The current master does not appear to produce output via the fallback ICC profile. For example:

[kleisauke@pc-kaw ~]$ wget https://github.com/lovell/sharp/raw/master/test/fixtures/cielab-dagams.tiff
[kleisauke@pc-kaw ~]$ vips colourspace cielab-dagams.tiff cielab-dagams.v srgb

(vips:30470): VIPS-WARNING **: 13:54:35.304: Incompatible type for "RichTIFFIPTC"; tag ignored
[kleisauke@pc-kaw ~]$ vips icc_transform cielab-dagams.v x.v srgb --input-profile=srgb --intent=perceptual --embedded=true

(vips:30490): VIPS-WARNING **: 13:54:41.133: profile colourspace differs from image
icc_transform: no input profile

(same output with vipsthumbnail cielab-dagams.tiff --size 128 --iprofile srgb --eprofile srgb)

This worked fine on vips 8.7.4:

[kleisauke@pc-kaw ~]$ vips colourspace cielab-dagams.tiff cielab-dagams.v srgb

(vips:9654): VIPS-WARNING **: 14:01:24.103: Incompatible type for "RichTIFFIPTC"; tag ignored
[kleisauke@pc-kaw ~]$ wget https://github.com/libvips/nip2/raw/master/share/nip2/data/sRGB.icm
[kleisauke@pc-kaw ~]$ vips icc_transform cielab-dagams.v x.v sRGB.icm --input-profile=sRGB.icm --intent=perceptual --embedded=true

(vips:9794): VIPS-WARNING **: 14:01:28.219: embedded profile colourspace differs from image

See #730 for more background information regarding this cielab-dagams.tiff image.

Originally posted by @kleisauke in #1194 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions