Skip to content

How do you silence "VIPS-INFO" output on CentOS 6 libvips build? #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elohanlon opened this issue Nov 6, 2020 · 8 comments
Closed

How do you silence "VIPS-INFO" output on CentOS 6 libvips build? #1876

elohanlon opened this issue Nov 6, 2020 · 8 comments
Labels

Comments

@elohanlon
Copy link

elohanlon commented Nov 6, 2020

When I build libvips 8.10.2 on CentOS 6 (which is my target platform in this case), vipsthumbnail always outputs a bunch of 'VIPS-INFO' log lines, but the same build steps result in (expected) silent operation on CentOS 7.

Command: vipsthumbnail owl.jpg --smartcrop attention -s 128

CentOS 6:

$ vipsthumbnail owl.jpg --smartcrop attention -s 128
VIPS-INFO: thumbnailing owl.jpg
VIPS-INFO: selected loader is VipsForeignLoadJpegFile
VIPS-INFO: input size is 600 x 397
VIPS-INFO: loading with factor 1 pre-shrink
VIPS-INFO: pre-shrunk size is 600 x 397
VIPS-INFO: converting to processing space srgb
VIPS-INFO: residual reducev by 0.322418
VIPS-INFO: reducev: 19 point mask
VIPS-INFO: reducev: using vector path
VIPS-INFO: reducev sequential line cache
VIPS-INFO: residual reduceh by 0.322418
VIPS-INFO: reduceh: 19 point mask
VIPS-INFO: cropping to 128x128
VIPS-INFO: shrinkv by 2
VIPS-INFO: shrinkv sequential line cache
VIPS-INFO: shrinkh by 3
VIPS-INFO: residual reducev by 0.5
VIPS-INFO: reducev: 13 point mask
VIPS-INFO: reducev: using vector path
VIPS-INFO: reducev sequential line cache
VIPS-INFO: residual reduceh by 0.497409
VIPS-INFO: reduceh: 13 point mask
VIPS-INFO: convi: using C path
VIPS-INFO: gaussblur mask width 13
VIPS-INFO: convi: using C path
VIPS-INFO: convi: using C path
VIPS-INFO: thumbnailing owl.jpg as ./tn_owl.jpg
$

CentOS 7:

$ vipsthumbnail owl.jpg --smartcrop attention -s 128
$

Is it possible that I need to pass an extra configure argument during the CentOS 6 build steps to hide the default display of these VIPS-INFO log lines?

In addition to libvips 8.10.2, I'm also seeing "VIPS-INFO" output appearing by default when I build libvips 8.7.4 or 8.8.0 on CentOS 6.

@elohanlon elohanlon changed the title How do you silence "VIPS-INFO" output on CentOS 6 build? How do you silence "VIPS-INFO" output on CentOS 6 libvips build? Nov 6, 2020
@jcupitt
Copy link
Member

jcupitt commented Nov 6, 2020

Hi @elohanlon,

libvips uses the glib logging framework, so messages are being produced by that somehow:

https://developer.gnome.org/glib/unstable/glib-Message-Logging.html

Perhaps something in your system has set the G_DEBUG env var? Or maybe your platform glib has been built with info logging permanently enabled?

@elohanlon
Copy link
Author

HI @jcupitt,

Thanks for the quick reply, and the info! I'll look into the glib settings!

@kleisauke
Copy link
Member

kleisauke commented Nov 9, 2020

I think the problem here is that prior GLib version 2.32 log messages at levels INFO or DEBUG are shown by default (CentOS 6 ships with GLib 2.28.8). AFAIK, there is no way to disable this behaviour with environment variables.

Perhaps we could disable these messages for these older GLib versions unless the G_MESSAGES_DEBUG environment variable is set? This should match the behaviour of GLib 2.31 and newer.

See for example this untested patch:

Patch
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Kleis Auke Wolthuizen <github@kleisauke.nl>
Date: Mon, 9 Nov 2020 21:59:00 +0100
Subject: [PATCH 1/1] Don't print debug/info output with GLib older than 2.31



diff --git a/libvips/iofuncs/init.c b/libvips/iofuncs/init.c
index 1111111..2222222 100644
--- a/libvips/iofuncs/init.c
+++ b/libvips/iofuncs/init.c
@@ -284,6 +284,28 @@ empty_log_handler( const gchar *log_domain, GLogLevelFlags log_level,
 {       
 }
 
+#if !GLIB_CHECK_VERSION( 2, 31, 0 )
+/* Ensure to disable debug/info logging by default unless G_MESSAGES_DEBUG is
+ * set to an appropriate value (this matches GLib 2.31.0 and newer).
+ */
+static void
+default_log_handler( const gchar *log_domain, GLogLevelFlags log_level,
+	const gchar *message, gpointer user_data )
+{
+	const char *domains;
+
+	if( log_level & (G_LOG_LEVEL_DEBUG | G_LOG_LEVEL_INFO) ) {
+		domains = g_getenv( "G_MESSAGES_DEBUG" );
+		if( !domains || (!g_str_equal( domains, "all" ) &&
+			!g_strrstr( domains, log_domain )) ) {
+	  		return;
+		}
+	}
+
+	g_log_default_handler( log_domain, log_level, message, user_data );
+}
+#endif /*!GLIB_CHECK_VERSION( 2, 31, 0 )*/
+
 /* Attempt to set a minimum stacksize. This can be important on systems with a
  * very low default, like musl.
  */
@@ -318,10 +340,6 @@ set_stacksize( guint64 size )
 static void
 vips_verbose( void ) 
 {
-	/* Older glibs were showing G_LOG_LEVEL_{INFO,DEBUG} messages
-	 * by default
-	 */
-#if GLIB_CHECK_VERSION ( 2, 31, 0 )
 	const char *old;
 
 	old = g_getenv( "G_MESSAGES_DEBUG" );
@@ -338,7 +356,6 @@ vips_verbose( void )
 
 		g_free( new );
 	}
-#endif /*GLIB_CHECK_VERSION( 2, 31, 0 )*/
 }
 
 /**
@@ -590,6 +607,11 @@ vips_init( const char *argv0 )
 		g_log_set_handler( G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, 
 			empty_log_handler, NULL );
 
+#if !GLIB_CHECK_VERSION( 2, 31, 0 )
+	g_log_set_handler( G_LOG_DOMAIN, G_LOG_LEVEL_INFO |
+		G_LOG_LEVEL_DEBUG, default_log_handler, NULL );
+#endif
+
 	/* Set a minimum stacksize, if we can.
 	 */
         if( (vips_min_stack_size = g_getenv( "VIPS_MIN_STACK_SIZE" )) )

@elohanlon
Copy link
Author

elohanlon commented Nov 10, 2020

@kleisauke I think you're right, and I didn't have any luck with environment variables. And @jcupitt, thank you for pointing me in the right direction with glib! Here's what I found, along with some more info about my situation:

Prior to creating this github issue, I ended up having to build glib myself because the CentOS 6 version that yum gave me (2.28.8) resulted in the VIPS-INFO messages AND some additional "GLib-GObject-CRITICAL" messages.

In CentOS 7, I still got the VIPS-INFO messages, but I didn't see the "GLib-GObject-CRITICAL" messages, so I figured the older version of glib was causing issues. So I built glib 2.57.1 on CentOS 6 (because I had an issue building 2.56.1) and then built libvips. The "GLib-GObject-CRITICAL" messages went away, but the VIPS-INFO ones remained.

I looked through the glib 2.57.1 configuration options and discovered "--enable-debug=no", and when I rebuilt glib with that option the VIPS-INFO messages went away. I'm guessing that whatever RPM builds glib on CentOS 6 and CentOS 7 doesn't make use of that parameter.

So hopefully that info helps anyone else who finds their way to this github issue for the same reason. @kleisauke I'd still be interested in knowing if your proposed patch hides the INFO messages, since that would probably be easier for people who don't want to build glib themselves.

@jcupitt
Copy link
Member

jcupitt commented Nov 10, 2020

Huh curious, you'd think --disable-debug would be the default setting.

Thanks for the update!

@elohanlon
Copy link
Author

elohanlon commented Nov 10, 2020

Hmm...If I'm interpreting this correctly, and glib_debug_default is used as the default value for the --enable-debug option, it looks like odd minor versions of glib enable debugging by default:

https://github.com/GNOME/glib/blob/2.57.1/configure.ac#L50-L53

# if the minor version number is odd, then we want debugging.  Otherwise
# we only want minimal debugging support.
m4_define([glib_debug_default],
          [m4_if(m4_eval(glib_minor_version % 2), [1], [yes], [minimum])])dnl

I wasn't expecting that, but this is the first time I've ever built glib, so that may be normal for that library. I'm going to test this out later on with a build of 2.58.3.

Still, I'm not sure why I was still getting debug output in the CentOS 7 2.56.1 rpm from yum. And the configure file for 2.28.8 seems to have the same default settings, so I'd expect debugging to be disabled for an even minor version: https://github.com/GNOME/glib/blob/2.28.8/configure.ac#L41-L44

jcupitt added a commit that referenced this issue Nov 10, 2020
Some old glibs can display INFO messages by default. Block these
ourselves.

See #1876
@jcupitt
Copy link
Member

jcupitt commented Nov 10, 2020

I've been experimenting with various older glibs. glib-2.30.2 seems to be a good test case -- you get the annoying INFO messages even if you build it with --enable-debug=no, which seems like a clear bug.

I've pushed a patch to 8.10 based on Kleis's suggestion. It seems to work, but what an ugly hack! But it does hide these messages unless you ask for them.

@elohanlon
Copy link
Author

I was planning on testing with even-number glib 2.58.3 on CentOS, but it turns out that the automake version I had was too old (require Automake 1.13.3, but have 1.11.1). But I was able to get even-number 2.56.4 to build after all and I'm glad to report that it does default to hiding the INFO messages, so I'll go with that version in the end.

Thank you for the patch to handle older versions! I'm glad it works despite the ugliness, haha.

@jcupitt jcupitt closed this as completed Dec 12, 2020
alon-ne added a commit to wix-playground/libvips that referenced this issue Dec 21, 2020
* better webp load sanity checking

see libvips@d93d9bb#r40846309

* block fuzz data over 100kb

Many codecs can take a huge amount of time attempting to read large
random objects. jpeg_read_header(), for example, can take ~10s on a 1mb
of random data.

Ignore fuzz objects over 100kb.

See https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24383

* deprecate vips_popen()

it didn't work well on win, and we no longer use it anyway

* detect RLE overflow in radiance

old-style radiance RLE could overflow harmlessly

see https://oss-fuzz.com/testcase-detail/4918518961930240

* better dbg msg in spngload

* try to work around some broken heic images

see libvips#1574

* revise heic thumbnail workaround

* Add C++ bindings for new_from_memory_steal()

new_from_memory_steal() will create a new image with the input
buffer and will "move" the data into the image. The buffer is then
managed by the image, and will be freed when it goes out of scope.

* Don't check g_signal_connect()'s return

* Remove cast in free() call

* Remove redundant part of comment

* Add parameter name for unused image

* fix typo

see libvips/pyvips#198 (comment)

thanks Tremeschin

* fix write ICC profile to webp

ooops, a typo broke ICC profile write to webp 18 days ago

thanks augustocdias

see libvips#1767

* put minimise support back into pdfload

* docs fix

pandoc changed the name of their top-level section node

* start 8.10.1

following the doc generation fix

* remove redefinition of typedefs

We had this in a couple of places:

	typedef struct _A A;
	typedef struct _A A;

Some old gccs (eg. centos6) throw errors for this.

See libvips#1774

* add missing funcs to public C API

The C API was missing vips_jpegload_source and vips_svgload_source.
Thanks to augustocdias.

See libvips#1780

* update wrapper script

fixes "make check".

* experiment with doxygen for C++ docs

* fix regression in thumbnail of pyr tiff

The new subifd pyramid thumbnail code broke the old page-based pyramid
detector.

Thanks tand826

See libvips#1784

* move vips-operators.h into the header

doxy hates #include inside classes

* Ensure magick buffer+file checks use consistent min length guard

Prevents a zero-length buffer from crashing GetImageMagick

It looks like the fix for magick7 in libvips#1642 is also now required
for magick6 as the assertion appears to have been backported.

* add optional params to doc strings

* Ensure magick buffer+file checks use consistent min length guard

Prevents a zero-length buffer from crashing GetImageMagick

It looks like the fix for magick7 in libvips#1642 is also now required
for magick6 as the assertion appears to have been backported.

* prevent 0-length buffers reaching imagemagick

im6 seems to have added an assert for this

see libvips#1785

* add doxygen to the build system

configure tests for it, make runs it, make install copies the generated
html

* revise cpp codegen again

use f'' strings, polish formatting

* add doc comments for VError and VInterpolate

* a few more doc comments

* convert no-profile CMYK to RGB on save

Use the fallback cmyk profile to convert to RGB on save if the image has
no embedded profile.

Thanks augustocdias.

See libvips#1767

* fix some unknown types

We were missing VipsInterpolate and guint64. Add guint64 set() as well.

see libvips@636e265#commitcomment-41589463

* improve C++ API

Make VObject inheritance public, so we can have a single set() for all
VObject-derived types.

* note how to list interpolators

* Ensure SVG loader skips input with chars outside x09-x7F range

Add test with example valid WebP image that happens to contain
the string '<svg' within its compressed image data.

* Ensure SVG loader skips input with chars outside x09-x7F range

Add test with example valid WebP image that happens to contain
the string '<svg' within its compressed image data.

* note svg fix

* improve docs for arrayjoin

see libvips/pyvips#202

* Fix a small memory leak in sinkscreen

* start sinkscreen thread on first use

we were starting the sinkscreen background thread during vips_init() --
instead, start it on first use

see libvips#1792

* fix typo

* better mask sizing for gaussmat

We were calculating the mask size incorrectly for small masks.

Thanks johntrunc

see libvips#1793

* fix handling of "squash" param in tiffsave

the deprecated param was not being detected correctly, breaking vips7
compat in some cases

see libvips#1801

* fix jpegload autorotate

thanks chregu

see libvips/php-vips#105

* note render thread change in changelog

* update magick metadata naming

IM seem to have changed their rules for naming metadata chunks. They are
now lowercase and ICM is renamed to ICC. Add a simple test too.

See libvips/ruby-vips#246

* revise doxy flags to configure

* add a README.md for cpp

* add some more C++ docs

* more C++ docs

* better dint rules

We had some special cases coded for dhint inheritance, but they could
fail in some edge cases. Revert to something simpler and more
predictable.

see libvips#1810

* don't add generated latex to repo

* finish C++ doc comments

* integrate new C++ docs in main docs

* more small doc tweaks

* Ensure VImage::set uses class to determine type

Prevents null GType and associated segfault

* don't set JFIF res if we will set EXIF res

Some JPEG loaders give priority to JFIF resolution over EXIF resolution
tags. This patch makes libvips not write the JFIF res tags if it will be
writing the EXIF res tags.

See libvips/ruby-vips#247

* typo in recent cpp API improvements

We had G_VALUE_TYPE instead of G_OBJECT_TYPE, oops. Thanks @lovell.

see libvips#1812

* fix TIFF thumbnail of buffer and source

We had dropped a couple of patches.

see libvips#1815

* fix tiff thumbnail from buffer and source

We were missing the new tiff thumbnail logic on the source and buffer
paths.

see libvips#1815

* add a .gitignore for the new cpp api

to stop accidentally adding it to 8.10

* raise minimum libheif version to 1.3

We didn't compile with anything less than 1.3 anyway.

see libvips#1817

* block doxy latex output too

* libheif: expose speed parameter (currently AV1 compression only)

Supports both aom and rav1e encoders by limiting to a 0-8 range.

(The rav1e encoder accepts speed values of 9 and 10 but these
use 64x64 blocks more suited to video than images.)

* fix dzsave iiif dimensions

dzsave in iiif mode could set info.json dimensions off by one

thanks Linden6

see libvips#1818

* allow both dpi and scale to be set for pdfload

pdfload didn't allow both dpi and scale to be set. This patch makes the
two settings combine if both are given.

thanks le0daniel

see libvips#1824

* tiny thumbnail speedup

thumbnail can skip premultiply/unpre if there's no residual resize

* allow gaussblur sigma 0

meaning no blur (obviosuly)

* oop typo

* Verify ISO/3GPP2 signature in heifload is_a check

* Verify ISO/3GPP2 signature in heifload is_a check

* better heif signature detection

* heifload: simplify is_a check of first 4 bytes

Allow multiples of 4, up to 32, as chunk length

* heifload: simplify is_a check of first 4 bytes

Allow multiples of 4, up to 32, as chunk length

* revise heif sniffing again

* note VImage::new_from_memory_steal() in ChangeLog

plus doxy commnets etc., see libvips#1758

* Fix test failure on ARM-based Windows

The optional parameters of vips_gaussnoise were incorrectly
passed within vips_fractsurf. This was discovered when running
the libvips testsuite on Windows 10 IoT (ARM32).

* Fix test failure on ARM-based Windows

The optional parameters of vips_gaussnoise were incorrectly
passed within vips_fractsurf. This was discovered when running
the libvips testsuite on Windows 10 IoT (ARM32).

* note fractsurf fix in changelog

* heifload: prevent reading beyond end of source buffer

* heifload: prevent reading beyond end of source buffer

* heifload: prevent reading beyond end of source buffer

* revise heifload EOF detection

VipsSource used a unix-style model where read() returns 0 to mean EOF.
libheif uses a model where a separate call to wait_for_file_size()
beforehand is used to check thaht the read will be OK, and then the
read() is expected to never fail.

We were trying to put EOF detection into libheif read(), but that's not
the right way to do it. Instead, test for EOF in wait_for_file_size().

see libvips#1833

* get docs building with goi 1.66+

It builds now, but some doc sections are missing. Fix this properly in
8.11.

See libvips#1836

* note improvements to iprofile

The docs had fallen behind a bit ... iprofile is no longer usually necessary.

see libvips#1843

* update vipsthumbnail docs for --export-profile

and --input-profile

* add stdin, stdout to vipsthumbnail

eg.

	vipsthumbnail stdin[page=2] -o .jpg[Q=90]

mirror of syntax in new_from_file etc.

* improve seek on pipes

There were a few issues in VipsSource around seeking on pipes. With this
patch, EOF detection is better, and pipe sources automatically turn into memory
sources when EOF is hit.

see libvips#1829

* revise pipe sources (again)

Simplify and cleanup.

* pdfload was missing a rewind on source

* add a test for vipsthumbnail of stdin/stdout

* libheif: expose speed parameter (currently AV1 compression only)

Supports both aom and rav1e encoders by limiting to a 0-8 range.

(The rav1e encoder accepts speed values of 9 and 10 but these
use 64x64 blocks more suited to video than images.)

* note new "speed" param in heifsave

To help support the rapid move to AVIF.

see libvips#1819 (comment)

* fix a regression in the C path for dilate/erode

A ++ had been dropped in the recent refactoring. Credit to kleisauke.

See libvips#1846

* fix build with libheif save buit not load

We had some definitions inside the #ifdef HEIFLOAD.

Thanks estepnv

libvips#1844

* heifload: expose heif-compression metadata

* Speed up VIPS_ARGUMENT_COLLECT_SET

By using G_VALUE_COLLECT_INIT, see:
https://bugzilla.gnome.org/show_bug.cgi?id=603590

* fix heifload with libheif 1.6

heif_avif wasn't added until libheif 1.7

* Separate lock for PDFium

* move the pdfium lock init

move it inside the existing ONCE

see libvips#1857

* better GraphicsMagick image write

We were not setting matte or depth correctly, thanks bfriesen.

* get pdium load working again

It had bitrotted a bit. Thanks @Projkt-James.

See libvips#1400

* fix pdfium mutex init

We need to make the mutex in _class_init, not _build, since we can lock
even if _build is not called.

* add pdfium load from source

* improve BGRA -> RGBA conversion

* revise BGRA->RGBA

* relax is_a heic test rules

32 was a little too small, see libvips#1861

* fix vips7 webp load

webp load using the vips7 interface was crashing, thanks barryspearce

see libvips#1860

* fix out of bounds exif read in heifload

We were subtracting 4 from the length of the exif data block without
checking that there were 4 or more bytes there.

* only remove main image (ifd0) orientation tag

we were stripping all orientation tags on autorot

see libvips#1865

* fix two small bugs in test_connections.c

We were passing NULL rather than argv0 to VIPS_INIT(), and we were not
freeing the loaded file.

thanks zodf0055980

see libvips#1867

* add mssing g_option_context_free() to vipsedit

We were not freeing the argument parse context in vipsedit.c.

Thanks zodf0055980

see libvips#1868

* Revert "Remove round-to-nearest behaviour"

This reverts commit ac30bad

* Round sum values to the nearest integer in *_notab

* Fix centre convention

* fix out of bounds read in tiffload

libtiff can change the value of some fields while scanning a corrupt
TIFF file and this could trigger an out of bounds read.

This patch makes tiffload more cautious about rescanning a TIFF
directory before reading out header fields.

* fix tiff pyramid save region-shrink

we'd forgotton to connect it up

thanks imgifty

see libvips#1875

* add tests for tiff pyr save region-shrink flag

we were testing the flag before, but not that the result was correct

see libvips#1875

* flush target at end of write

we were missing end-of-write flushes on four save operations

thanks harukizaemon

see libvips/ruby-vips#256

* missing include

* Update Examples.md

Just some issues I found while testing the examples:
- Reference on header for the file try255.py
- Typo on parameter from bigtif to bigtiff
- Use explicit call to python interpreter from command line

* update examples to py3

* fix compiler warning

* block annoying INFO messages on some older glibs

Some old glibs can display INFO messages by default. Block these
ourselves.

See libvips#1876

* fix icc-profiles and dzsave --no-strip

We were not copying metadata down pyramid layers in dzsave, so
--no-strip didn't allow icc profiles on tiles.

Thanks altert

See libvips#1879

* Ensure that streams are properly read in spngload

* better GraphicsMagick image write

We were not setting matte or depth correctly, thanks bfriesen.

* add read loops to heif and ppm as well

We were not looping on vips_source_read() in these loaders, so they
could fail when reading from very slow pipes.

See kleisauke/net-vips#101

* fix changelog after GM backport

* note read fixes in changelog

* forgot to advance the buffer pointers

thanks kleis

see kleisauke/net-vips#101 (comment)

* add read loops to gifload

and check for error in ppnmload.

* add "seed" param to perlin, worley and gaussnoise

see libvips#1884

* block 0 width or height images from imagemagick

IM could return 0 width and/or height for some crafted images. Block
these.

Thanks @Koen1999.

See libvips#1890

* oops typo in magick7 load

* fix a possible read loop for truncated gifs

* gifload: ensure total height of all pages is sanitised

* reformat

* backport gifheight check

ensure gifheight can't oevrflow

see libvips#1892

* oops typo in magick7 load

* make ppm load default to msb first

We has lsb first as the default, breaking 16-bit PPM load. Thanks ewelot.

see libvips#1894

* byteswap on ppm save, if necessary

this was missing, thanks ewelot

see libvips#1894

* Ensure vipsload only byte swaps if necessary

Prior to this commit, MSB-ordered vips images were always byte swapped
on both little- and big endian systems. And LSB-ordered vips images
were loaded without a byte swap. This works correctly on little endian
systems, but will not work on big endian systems where the byte swap
must be done vice versa.

This commit ensures that the byte swap only takes place when needed.

See libvips#1847.

* Simplify MSB-ordered image check

* Determine endianness at compile time

* Port Ruby test case to Python

* force binary mode for connections on win

stdin / stdout (for example) are created in text mode by default on
win. We need to flip them to binary mode for connection read and write.

See https://stackoverflow.com/questions/65014352/pipe-libvips-cli-output-to-stdout-in-windows

* better test for output to target

We used to enable write to stdout if the first character of an output filename
was ".", eg.:

	vips copy x.jpg .png

But this will also enable write to stdout for things like:

	vips copy x.jpg ./y.png

This patch also tests that the rightmost "." in a filename is also the
first character.

Thanks barryspearce

See libvips#1906

* block deprecation warnings from libgsf

with an uglu gcc progma

* docs clarification

libvips#1912

* don't add date in ppmsave if @strip is set

see libvips#1913

* add is_a_source to ppmload

ppmload_source was missing an ia_a test

see libvips#1915

* note ppmload fix

* fix ppmsave regression

ppm strip dropped magic number

* n comment

* webpload: ensure first frame is not blended

* make webp frame blend do doround to nearest

see libvips#1918

* fix heif load fails with 0 length metadata

fixes libvips#1901

* fix range clips for casts to and from int

Fix two bugs:

- clip in casts from int32 and uint32 could overflow -- do these as gint64 now

- clip in casts from float to int could overflow since float32 can't
  represent the full range of int32 without losing precision -- do these
  as double

And add some more tests.

Thanks ewelot.

see libvips#1922

* note HEIC fix in changelog

see libvips#1921

* fix heif load fails with 0 length metadata

fixes libvips#1901

* note HEIC fix in changelog

see libvips#1921

* forgot changelog update

* improve website link in docs

it was being rewritten by the export script

see libvips#1928

* fix spng detection

This patch was dropped from 8.10.3 release 1, annoyingly.

* start 8.10.4

with a dropped patch from 8.10.3

* allow spng.pc and libspng.ps for libspng discovery

* webpload: prevent divide-by-zero when blending pixels

Adds a test case to prevent regression - see commit 6eaf1ed

* bump version for animated webp load fix

Co-authored-by: John Cupitt <jcupitt@gmail.com>
Co-authored-by: Kyle Schwarz <zeranoe@gmail.com>
Co-authored-by: Lovell Fuller <github@lovell.info>
Co-authored-by: Kleis Auke Wolthuizen <github@kleisauke.nl>
Co-authored-by: DarthSim <darthsim@gmail.com>
Co-authored-by: Antonio Martínez <amalbala@gmail.com>
Co-authored-by: Daniel Dennedy <ddennedy@gopro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants