-
-
Notifications
You must be signed in to change notification settings - Fork 698
The long and winding road to 8.13 #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@dloebl we should get some GIF fixes in too. Please add some notes to the TODO above if you like. |
Would love to see this one 😉 |
pyvips now has support in master for the new targetcustom stuff, and it seems to work well |
I just emailed Remi Collet with a patch that migrates the vips spec file to build with Meson for the upcoming 8.13 release. While doing so, I noticed 2 things:
|
OK, I think we're almost ready. Shall we feature-freeze and do a release? |
I have nothing to add for 8.13, so I'm fine with a feature freeze and a possible release candidate. Though, I noticed some pending cgifsave PRs for possible inclusion. |
I think we need to do another round of GIF polishing :( I'll make an issue with some benchmarks. |
I think I found another cgifsave issue --- this GIF: When copied like this:
Becomes this: I think the problem is that the colour table is being improved by the render pass. It's improving the colour table based on the first frame and that of course makes it much worse for the later frames. We probably need to remove the improve ctable feature in global cmap mode. |
Interesting find. This looks similar to the issue mentioned here: #2797 (comment) libvips/libvips/foreign/cgifsave.c Line 629 in 6260a37
|
Yes, it's a simple change, just read out the palette before remapping the frame. I'll make a PR once the current two cgif PRs merge. |
OK, the palette improvement issue is done. I've started writing a "what's new" post -- any comments? https://github.com/libvips/libvips/blob/gh-pages-8.13/_posts/2022-05-28-What's-new-in-8.13.md
|
I don't think we should remove |
Release candidate 1: https://github.com/libvips/libvips/releases/tag/v8.13.0-rc1 Release notes posted: https://www.libvips.org/2022/05/28/What's-new-in-8.13.html API docs: https://www.libvips.org/API/8.13/ |
... let's wait a week for people to test rc1, and if no one finds anything too bad, we'll announce 8.13.0 on 26 June. |
It looks like there are enough rc1 issues to need an rc2 next weekend. |
When building from source in a container (with lima) I get the following error:
The Dockerfile:
|
Perhaps we can do something about this:
has a one-pixel black line down the left of |
Solved the Debian build issue by installing 'bc':
thanks @netanel-r |
Here's https://github.com/libvips/libvips/releases/tag/v8.13.0-rc2 Let's aim for release on Sunday 17 July (assuming nothing too bad happens in testing). |
Any chance for a Windows release? The last Windows binary 8.12.1 still has a bug impacting me, that was fixed in 8.12.2. 🙏 |
Kleis has made 8.12.2 binaries here: https://github.com/libvips/build-win64-mxe/releases/tag/v8.12.2 And 8.13.0-rc2 here: https://github.com/libvips/build-win64-mxe/releases/tag/v8.13.0-rc2 |
Ooof right, sorry, I was on holiday and had less time than I expected. Now I'm back! A few more bugfixes have gone in this week, but only a few. Shall we do 8.13.0 now? Any thoughts? |
Nothing extra from me for 8.13, so feel free to |
Woo hoo! Well done us! |
Just publicity left to do now. Please feel feel free to tweet, post on reddit, whatever you like. |
Is it already Christmas? |
Aim for a release in late May.
TODO
Milestone: https://github.com/libvips/libvips/milestone/11
The text was updated successfully, but these errors were encountered: