Skip to content

cgifsave: inter-frame maxerror might be unlimited #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dloebl opened this issue Jun 13, 2022 · 1 comment · Fixed by #2870
Closed

cgifsave: inter-frame maxerror might be unlimited #2864

dloebl opened this issue Jun 13, 2022 · 1 comment · Fixed by #2870

Comments

@dloebl
Copy link
Contributor

dloebl commented Jun 13, 2022

With some animated GIFs, the inter-frame maxerror can be unlimited. This can happen because the error is within the threshold from Frame A to Frame B but adds up with every frame.
Previously, we always compared against a HEAD frame in cgifsave. Unfortunately, this HEAD frame logic has been recently removed with #2853.

Example:
issue.gif

vips copy issue.gif[n=-1] out.gif[interframe-maxerror=4]
original output
issue out

As you can see, the output animation is just black - which is not as expected of course.
@jcupitt
Copy link
Member

jcupitt commented Jun 13, 2022

That's a good test image. You're right, it's all broken, I'll have a look.

@DarthSim DarthSim mentioned this issue Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cgifsave: remove regressions from 2853 DarthSim/libvips
2 participants
@jcupitt @dloebl