Never set the PFM header to little endian #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a little more logging for jxlload
* Add Magic Kernel support * Fix range for MKS2013 * Improve readability for MKS2013 filter * Add Magic Kernel test * Update ChangeLog
PFM files are always written in big endian: https://github.com/libvips/libvips/blob/master/libvips/foreign/ppmsave.c#L459 But the header is set to little endian if on a big endian machine (!) https://github.com/libvips/libvips/blob/master/libvips/foreign/ppmsave.c#L414-L415 Fixes libvips#4241.
|
!!!! Well, that was pretty dumb. Thank you very much for finding this @agoode. Let's put this in 8.16 (stable branch), it seems like a straightforward change. |
|
Ooop, more dumbness, I messed that up. Fixed with f06db0f I hope. |
|
Retargeting PRs to stable branches can be somewhat cumbersome. :( Hopefully PR #4162 makes the process of backporting commits to these branches a bit smoother. |
|
Will this get merged back to master eventually? |
|
Yes, we always merge stable branches to master, I just hadn't got around to it. I'll do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PFM files are always written in big endian:
https://github.com/libvips/libvips/blob/master/libvips/foreign/ppmsave.c#L459
But the header is set to little endian if on a big endian machine (!) https://github.com/libvips/libvips/blob/master/libvips/foreign/ppmsave.c#L414-L415
Fixes #4241.