Merge pull request #259 from jetthoughts/adds-linter

jcupitt · web-flow · commit 5cd7701fbac2 · 2020-12-19T15:51:33.000Z
Adds linter to make sure that code is consistent
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,6 +10,23 @@ env:
   SPEC_OPTS: '--backtrace'
 
 jobs:
+  name: Lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '2.7'
+          bundler-cache: true
+
+      - name: Run Standard Ruby linter
+        run: bin/standardrb --no-fix --fail-fast
+        continue-on-error: true
+
   test:
     name: Functional Testing
     runs-on: ubuntu-20.04 # In order to install libvips 8.9+ version
diff --git a/.standard.yml b/.standard.yml
@@ -0,0 +1,8 @@
+fix: false              # default: false
+parallel: true          # default: false
+format: progress        # default: Standard::Formatter
+ruby_version: 2.5       # default: RUBY_VERSION
+default_ignores: false  # default: true
+
+ignore:                 # default: []
+  - 'vendor/**/*'
diff --git a/Gemfile b/Gemfile
@@ -5,3 +5,4 @@ gemspec
 
 gem 'github-markup'
 gem 'redcarpet', platforms: :ruby
+gem 'standard', platforms: :ruby
diff --git a/TODO b/TODO
@@ -9,7 +9,7 @@
 
 - Lint.
 
-	bundle exec rake rubocop
+	bundle exec standardrb
 
 - Reinstall local copy of gem after a change.
 
@@ -31,10 +31,6 @@
 	require 'vips'; Vips::Yard.generate
 	^D
 
-- Regenerate `.rubocop_todo.yml`.
-
-	bundle exec rubocop --auto-gen-config
-
 - Regenerate docs.
 
 	bundle exec rake yard

Original file line number	Diff line number	Diff line change
`@@ -5,3 +5,4 @@ gemspec`
`5`	`5`
`6`	`6`	`gem 'github-markup'`
`7`	`7`	`gem 'redcarpet', platforms: :ruby`
	`8`	`+gem 'standard', platforms: :ruby`