Skip to content

Thumbnail gif file with crop: :centre always creates 1 scene gif #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andreyruby opened this issue Jul 20, 2022 · 1 comment
Open

Thumbnail gif file with crop: :centre always creates 1 scene gif #344

andreyruby opened this issue Jul 20, 2022 · 1 comment
Labels
blocked-upstream bug

Comments

@andreyruby
Copy link

andreyruby commented Jul 20, 2022 •
edited
Loading

Describe the bug

Vips::Image.thumbnail("filename.gif[n=-1]", 200, height: 200, crop: :centre) with animated GIF file saves static file with 1 scene only.

Without crop: :centre it saves animated file correctly

I used file https://i.pinimg.com/originals/96/50/f0/9650f01cd3334952b075f8cf55bedd60.gif for testing

To Reproduce
Steps to reproduce the behavior:
Run ruby script

# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "ruby-vips"
  gem 'down'
end

GLib::logger.level = Logger::DEBUG

tempfile = Down.download("https://i.pinimg.com/originals/96/50/f0/9650f01cd3334952b075f8cf55bedd60.gif")

resized_image = Vips::Image.thumbnail("#{tempfile.path}[n=-1]", 400, height: 400, crop: :centre)
resized_image.write_to_file "/tmp/rabbit-with-crop.gif"
`browse /tmp/rabbit-with-crop.gif`

Expected behavior
File must be animated with all scenes cropped

Additional context
I have libvips 8.13rc1 compiled with cgif
@andreyruby andreyruby added the bug label Jul 20, 2022
@jcupitt
Copy link
Member

jcupitt commented Jul 20, 2022

Hi @aglushkov,

vipsthumbnail has logic for shrinking animated images. but not for cropping them. There's an enhancement issue here libvips/libvips#2668

@p8 p8 mentioned this issue Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-upstream bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcupitt @andreyruby