Make it compatible with libxml2 >= 2.12.0

kjellahl · kjellahl · commit 49471812d57a · 2023-11-18T18:34:07.000+01:00
* libxml++/document.cc:
* libxml++/dtd.cc:
* libxml++/nodes/entitydeclaration.cc:
* libxml++/nodes/entityreference.cc:
* libxml++/validators/relaxngvalidator.cc: Modify #include directives.
* libxml++/keepblanks.cc: Ignore deprecation of xmlKeepBlanksDefault().
* tests/saxparser_chunk_parsing_inconsistent_state/main.cc:
Accept that MySaxParser::on_start_document() can be called before
MySaxParser::on_error().
diff --git a/libxml++/document.cc b/libxml++/document.cc
@@ -16,6 +16,7 @@
 
 #include <libxml/tree.h>
 #include <libxml/xinclude.h>
+#include <libxml/xmlsave.h>
 #include <libxml/parser.h> // XML_PARSE_NOXINCNODE, XML_PARSE_NOBASEFIX
 
 #include <iostream>
diff --git a/libxml++/dtd.cc b/libxml++/dtd.cc
@@ -8,7 +8,7 @@
 #include <libxml++/exceptions/parse_error.h>
 #include <libxml++/io/istreamparserinputbuffer.h>
 
-#include <libxml/tree.h>
+#include <libxml/parser.h>
 
 #include <sstream>
 
diff --git a/libxml++/keepblanks.cc b/libxml++/keepblanks.cc
@@ -5,8 +5,11 @@
  * included with libxml++ as the file COPYING.
  */
 
-#include <libxml++/keepblanks.h>
+// xmlKeepBlanksDefault() is deprecated since libxml2 2.12.0.
+// Ignore deprecations here.
+#define XML_DEPRECATED
 
+#include <libxml++/keepblanks.h>
 #include <libxml/globals.h>
 
 namespace xmlpp
diff --git a/libxml++/nodes/entitydeclaration.cc b/libxml++/nodes/entitydeclaration.cc
@@ -5,7 +5,7 @@
  */
 
 #include <libxml++/nodes/entitydeclaration.h>
-#include <libxml/tree.h>
+#include <libxml/entities.h>
 
 namespace xmlpp
 {
diff --git a/libxml++/nodes/entityreference.cc b/libxml++/nodes/entityreference.cc
@@ -6,7 +6,7 @@
 
 #include <libxml++/nodes/entityreference.h>
 
-#include <libxml/tree.h>
+#include <libxml/entities.h>
 
 namespace xmlpp
 {
diff --git a/libxml++/validators/relaxngvalidator.cc b/libxml++/validators/relaxngvalidator.cc
@@ -22,6 +22,7 @@
 #include "libxml++/parsers/domparser.h"
 #include "libxml++/relaxngschema.h"
 
+#include <libxml/tree.h>
 #include <libxml/relaxng.h>
 
 namespace xmlpp
diff --git a/tests/saxparser_chunk_parsing_inconsistent_state/main.cc b/tests/saxparser_chunk_parsing_inconsistent_state/main.cc
@@ -24,10 +24,14 @@
 
 class MySaxParser : public xmlpp::SaxParser
 {
+public:
+  bool throw_on_start_doc = true;
+
 protected:
   void on_start_document() override
   {
-    throw std::runtime_error("some custom runtime exception");
+    if (throw_on_start_doc)
+      throw std::runtime_error("some custom runtime exception");
   }
   void on_error(const xmlpp::ustring& /* text */) override
   {
@@ -43,6 +47,9 @@ int main()
     bool exceptionThrown = false;
     try
     {
+      // Depending on the libxml2 version, MySaxParser::on_start_document()
+      // may or may not be called before MySaxParser::on_error().
+      parser.throw_on_start_doc = false;
       parser.parse_chunk("<?");
       parser.finish_chunk_parsing();
     }
@@ -61,6 +68,7 @@ int main()
     exceptionThrown = false;
     try
     {
+      parser.throw_on_start_doc = true;
       std::stringstream ss("<root></root>");
       parser.parse_stream(ss);
     }

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*/`
`6`	`6`
`7`	`7`	`#include <libxml++/nodes/entitydeclaration.h>`
`8`		`-#include <libxml/tree.h>`
	`8`	`+#include <libxml/entities.h>`
`9`	`9`
`10`	`10`	`namespace xmlpp`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`#include <libxml++/nodes/entityreference.h>`
`8`	`8`
`9`		`-#include <libxml/tree.h>`
	`9`	`+#include <libxml/entities.h>`
`10`	`10`
`11`	`11`	`namespace xmlpp`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,14 @@`
`24`	`24`
`25`	`25`	`class MySaxParser : public xmlpp::SaxParser`
`26`	`26`	`{`
	`27`	`+public:`
	`28`	`+ bool throw_on_start_doc = true;`
	`29`	`+`
`27`	`30`	`protected:`
`28`	`31`	`void on_start_document() override`
`29`	`32`	`{`
`30`		`- throw std::runtime_error("some custom runtime exception");`
	`33`	`+ if (throw_on_start_doc)`
	`34`	`+ throw std::runtime_error("some custom runtime exception");`
`31`	`35`	`}`
`32`	`36`	`void on_error(const xmlpp::ustring& /* text */) override`
`33`	`37`	`{`
`@@ -43,6 +47,9 @@ int main()`
`43`	`47`	`bool exceptionThrown = false;`
`44`	`48`	`try`
`45`	`49`	`{`
	`50`	`+ // Depending on the libxml2 version, MySaxParser::on_start_document()`
	`51`	`+ // may or may not be called before MySaxParser::on_error().`
	`52`	`+ parser.throw_on_start_doc = false;`
`46`	`53`	`parser.parse_chunk("<?");`
`47`	`54`	`parser.finish_chunk_parsing();`
`48`	`55`	`}`
`@@ -61,6 +68,7 @@ int main()`
`61`	`68`	`exceptionThrown = false;`
`62`	`69`	`try`
`63`	`70`	`{`
	`71`	`+ parser.throw_on_start_doc = true;`
`64`	`72`	`std::stringstream ss("<root></root>");`
`65`	`73`	`parser.parse_stream(ss);`
`66`	`74`	`}`