Skip to content

Commit 685e665

Browse files
committed
Clean up Visual Studio build files
We no longer need to ignore warnings C4251, C4273 and C4275, and we will now use /EHsc, so we also no longer need to ignore warning C4530.
1 parent 6651484 commit 685e665

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

MSVC_NMake/config-msvc.mak

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ DEBUG_SUFFIX =
1414
!endif
1515

1616
LIBXMLXX_BASE_CFLAGS = \
17-
/I.\libxml++ /I.. \
18-
/wd4530 /wd4251 /wd4275 /EHsc \
17+
/I.\libxml++ /I.. /EHsc \
1918
/FImsvc_recommended_pragmas.h \
2019
/std:c++17
2120

meson.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ add_project_arguments(warning_flags, language: 'cpp')
236236
# MSVC: Ignore warnings that aren't really harmful, but make those
237237
# that should not be overlooked stand out.
238238
if is_msvc
239-
foreach wd : ['/FImsvc_recommended_pragmas.h', '/wd4267', '/wd4530', '/wd4251', '/wd4273', '/wd4275']
239+
foreach wd : ['/FImsvc_recommended_pragmas.h', '/wd4267', '/EHsc' ]
240240
disabled_warning = cpp_compiler.get_supported_arguments(wd)
241241
add_project_arguments(disabled_warning, language: 'cpp')
242242
endforeach

0 commit comments

Comments
 (0)