meson: Don't override meson's cpp_eh option

talisein · talisein · commit 70f4198790e6 · 2022-06-23T10:17:44.000-07:00
From meson 0.51.0, cpp_eh defaults to /EHsc on windows. Passing it to
add_program_arguments() means downstream projects using cpp_eh=a will get
warnings.
diff --git a/meson.build b/meson.build
@@ -303,7 +303,6 @@ add_project_arguments(warning_flags, language: 'cpp')
 #       that should not be overlooked stand out.
 if is_msvc
   disable_warnings_list = [
-    '/EHsc',  # avoid warnings caused by exception handling model used
     '/utf-8', # Avoid C4819 unicode conversion warnings when building on CJK locales
     '/wd4706', # assignment within conditional expression
   ]

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,6 @@ add_project_arguments(warning_flags, language: 'cpp')`
`303`	`303`	`# that should not be overlooked stand out.`
`304`	`304`	`if is_msvc`
`305`	`305`	`disable_warnings_list = [`
`306`		`- '/EHsc', # avoid warnings caused by exception handling model used`
`307`	`306`	`'/utf-8', # Avoid C4819 unicode conversion warnings when building on CJK locales`
`308`	`307`	`'/wd4706', # assignment within conditional expression`
`309`	`308`	`]`