Add explicit keyword to some single-parameter constructors.

murraycu · murraycu · commit ce5da79c26bb · 2016-12-12T09:18:43.000+01:00
Noticed by cppcheck.
diff --git a/examples/dom_update_namespace/main.cc b/examples/dom_update_namespace/main.cc
@@ -43,7 +43,7 @@ class Tests
 class fail_exception : public std::exception
 {
   public:
-    fail_exception(const std::string& msg) : msg_(msg) {}
+    explicit fail_exception(const std::string& msg) : msg_(msg) {}
     ~fail_exception() noexcept override {}
     const char* what() const noexcept override { return msg_.c_str(); }
 
diff --git a/examples/sax_parser_build_dom/svgelement.h b/examples/sax_parser_build_dom/svgelement.h
@@ -32,7 +32,7 @@ class Element : public xmlpp::Element
 {
 public:
 
-  Element(xmlNode* node);
+  explicit Element(xmlNode* node);
   ~Element() override;
 
   // example custom methods
diff --git a/examples/sax_parser_build_dom/svggroup.h b/examples/sax_parser_build_dom/svggroup.h
@@ -30,7 +30,7 @@ namespace SVG {
 class Group : public Element
 {
 public:
-  Group(xmlNode* node)
+  explicit Group(xmlNode* node)
     : Element(node)
     {}
 };
diff --git a/examples/sax_parser_build_dom/svgparser.h b/examples/sax_parser_build_dom/svgparser.h
@@ -31,7 +31,7 @@ namespace SVG {
 class Parser : public xmlpp::SaxParser
 {
 public:
-  Parser(xmlpp::Document& document);
+  explicit Parser(xmlpp::Document& document);
   ~Parser() override;
 
 protected:
diff --git a/examples/sax_parser_build_dom/svgpath.h b/examples/sax_parser_build_dom/svgpath.h
@@ -31,7 +31,7 @@ namespace SVG {
 class Path : public Element
 {
 public:
-  Path(xmlNode* node)
+  explicit Path(xmlNode* node)
     : Element(node)
     {}
 
diff --git a/examples/textreader/main.cc b/examples/textreader/main.cc
@@ -31,7 +31,7 @@
 
 struct indent {
   int depth_;
-  indent(int depth): depth_(depth) {};
+  explicit indent(int depth): depth_(depth) {};
 };
 
 std::ostream & operator<<(std::ostream & o, indent const & in)
diff --git a/libxml++/parsers/textreader.cc b/libxml++/parsers/textreader.cc
@@ -12,7 +12,7 @@ namespace xmlpp
 class TextReader::PropertyReader
 {
 public:
-  PropertyReader(TextReader& owner)
+  explicit PropertyReader(TextReader& owner)
   : owner_(owner)
   {}
 
diff --git a/libxml++/relaxngschema.cc b/libxml++/relaxngschema.cc
@@ -31,7 +31,7 @@ namespace
   class RelaxNGSchemaParserContextHolder
   {
   public:
-    RelaxNGSchemaParserContextHolder(xmlRelaxNGParserCtxtPtr ctx) noexcept : ctx_(ctx) {}
+    explicit RelaxNGSchemaParserContextHolder(xmlRelaxNGParserCtxtPtr ctx) noexcept : ctx_(ctx) {}
     ~RelaxNGSchemaParserContextHolder() { if (ctx_) xmlRelaxNGFreeParserCtxt(ctx_); }
 
   private:
diff --git a/libxml++/xsdschema.cc b/libxml++/xsdschema.cc
@@ -29,7 +29,7 @@ namespace
   class XsdSchemaParserContextHolder
   {
   public:
-    XsdSchemaParserContextHolder(xmlSchemaParserCtxtPtr ctx) noexcept : ctx_(ctx) {}
+    explicit XsdSchemaParserContextHolder(xmlSchemaParserCtxtPtr ctx) noexcept : ctx_(ctx) {}
     ~XsdSchemaParserContextHolder() { if (ctx_) xmlSchemaFreeParserCtxt(ctx_); }
 
   private:

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class Tests`
`43`	`43`	`class fail_exception : public std::exception`
`44`	`44`	`{`
`45`	`45`	`public:`
`46`		`- fail_exception(const std::string& msg) : msg_(msg) {}`
	`46`	`+ explicit fail_exception(const std::string& msg) : msg_(msg) {}`
`47`	`47`	`~fail_exception() noexcept override {}`
`48`	`48`	`const char* what() const noexcept override { return msg_.c_str(); }`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class Element : public xmlpp::Element`
`32`	`32`	`{`
`33`	`33`	`public:`
`34`	`34`
`35`		`- Element(xmlNode* node);`
	`35`	`+ explicit Element(xmlNode* node);`
`36`	`36`	`~Element() override;`
`37`	`37`
`38`	`38`	`// example custom methods`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace SVG {`
`30`	`30`	`class Group : public Element`
`31`	`31`	`{`
`32`	`32`	`public:`
`33`		`- Group(xmlNode* node)`
	`33`	`+ explicit Group(xmlNode* node)`
`34`	`34`	`: Element(node)`
`35`	`35`	`{}`
`36`	`36`	`};`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ namespace SVG {`
`31`	`31`	`class Parser : public xmlpp::SaxParser`
`32`	`32`	`{`
`33`	`33`	`public:`
`34`		`- Parser(xmlpp::Document& document);`
	`34`	`+ explicit Parser(xmlpp::Document& document);`
`35`	`35`	`~Parser() override;`
`36`	`36`
`37`	`37`	`protected:`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ namespace xmlpp`
`12`	`12`	`class TextReader::PropertyReader`
`13`	`13`	`{`
`14`	`14`	`public:`
`15`		`- PropertyReader(TextReader& owner)`
	`15`	`+ explicit PropertyReader(TextReader& owner)`
`16`	`16`	`: owner_(owner)`
`17`	`17`	`{}`
`18`	`18`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ namespace`
`31`	`31`	`class RelaxNGSchemaParserContextHolder`
`32`	`32`	`{`
`33`	`33`	`public:`
`34`		`- RelaxNGSchemaParserContextHolder(xmlRelaxNGParserCtxtPtr ctx) noexcept : ctx_(ctx) {}`
	`34`	`+ explicit RelaxNGSchemaParserContextHolder(xmlRelaxNGParserCtxtPtr ctx) noexcept : ctx_(ctx) {}`
`35`	`35`	`~RelaxNGSchemaParserContextHolder() { if (ctx_) xmlRelaxNGFreeParserCtxt(ctx_); }`
`36`	`36`
`37`	`37`	`private:`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ namespace`
`29`	`29`	`class XsdSchemaParserContextHolder`
`30`	`30`	`{`
`31`	`31`	`public:`
`32`		`- XsdSchemaParserContextHolder(xmlSchemaParserCtxtPtr ctx) noexcept : ctx_(ctx) {}`
	`32`	`+ explicit XsdSchemaParserContextHolder(xmlSchemaParserCtxtPtr ctx) noexcept : ctx_(ctx) {}`
`33`	`33`	`~XsdSchemaParserContextHolder() { if (ctx_) xmlSchemaFreeParserCtxt(ctx_); }`
`34`	`34`
`35`	`35`	`private:`