Document: Test for nullptr in a constructor

Kjell Ahlstedt · Kjell Ahlstedt · commit fa1ca3e3a02d · 2016-01-07T09:54:14.000+01:00
In Document(_xmlDoc* doc), throw an exception if doc==nullptr.
diff --git a/libxml++/document.cc b/libxml++/document.cc
@@ -179,6 +179,9 @@ Document::Document(const Glib::ustring& version)
 Document::Document(xmlDoc* doc)
   : impl_(doc)
 {
+  if (!impl_)
+    throw internal_error("xmlDoc pointer cannot be nullptr");
+
   impl_->_private = this;
 }
 
diff --git a/libxml++/document.h b/libxml++/document.h
@@ -85,6 +85,7 @@ class Document : public NonCopyable
    * The created xmlpp::Document takes ownership of the xmlDoc.
    * When the Document is deleted, so is the xmlDoc and all its nodes.
    * @param doc A pointer to an xmlDoc struct. Must not be <tt>nullptr</tt>.
+   * @throws xmlpp::internal_error If @a doc is <tt>nullptr</tt>.
    */
   explicit Document(_xmlDoc* doc);
 

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,9 @@ Document::Document(const Glib::ustring& version)`
`179`	`179`	`Document::Document(xmlDoc* doc)`
`180`	`180`	`: impl_(doc)`
`181`	`181`	`{`
	`182`	`+ if (!impl_)`
	`183`	`+ throw internal_error("xmlDoc pointer cannot be nullptr");`
	`184`	`+`
`182`	`185`	`impl_->_private = this;`
`183`	`186`	`}`
`184`	`187`