[macos] build: add build-number and buid-name arguments (flutter#53928)

hpoul · web-flow · commit 3441743c5c28 · 2020-04-11T13:20:01.000-07:00
diff --git a/packages/flutter_tools/lib/src/commands/build_macos.dart b/packages/flutter_tools/lib/src/commands/build_macos.dart
@@ -23,6 +23,8 @@ class BuildMacosCommand extends BuildSubCommand {
     addBuildModeFlags();
     addDartObfuscationOption();
     usesExtraFrontendOptions();
+    usesBuildNumberOption();
+    usesBuildNameOption();
   }
 
   @override
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
@@ -211,6 +211,34 @@ void main() {
     FeatureFlags: () => TestFeatureFlags(isMacOSEnabled: true),
   });
 
+  testUsingContext('macOS build supports build-name and build-number', () async {
+    final BuildCommand command = BuildCommand();
+    createMinimalMockProjectFiles();
+
+    await createTestCommandRunner(command).run(
+      const <String>[
+        'build',
+        'macos',
+        '--debug',
+        '--build-name=1.2.3',
+        '--build-number=42',
+      ],
+    );
+    final String contents = fileSystem
+      .file('./macos/Flutter/ephemeral/Flutter-Generated.xcconfig')
+      .readAsStringSync();
+
+    expect(contents, contains('FLUTTER_BUILD_NAME=1.2.3'));
+    expect(contents, contains('FLUTTER_BUILD_NUMBER=42'));
+  }, overrides: <Type, Generator>{
+    FileSystem: () => fileSystem,
+    ProcessManager: () => FakeProcessManager.list(<FakeCommand>[
+      setUpMockXcodeBuildHandler('Debug')
+    ]),
+    Platform: () => macosPlatform,
+    FeatureFlags: () => TestFeatureFlags(isMacOSEnabled: true),
+  });
+
   testUsingContext('Refuses to build for macOS when feature is disabled', () {
     final CommandRunner<void> runner = createTestCommandRunner(BuildCommand());
 

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ class BuildMacosCommand extends BuildSubCommand {`
`23`	`23`	`addBuildModeFlags();`
`24`	`24`	`addDartObfuscationOption();`
`25`	`25`	`usesExtraFrontendOptions();`
	`26`	`+ usesBuildNumberOption();`
	`27`	`+ usesBuildNameOption();`
`26`	`28`	`}`
`27`	`29`
`28`	`30`	`@override`