Fix docker tag during upload as well (flutter#46252)

tvolkert · web-flow · commit 55f0bdc03358 · 2019-12-09T12:56:47.000-08:00
In flutter#46035, we fixed the docker tag to be a legal tag during build. This PR makes the corresponding change to the tag during upload. Without this, we build the right tag, but then we try to upload the wrong tag.
diff --git a/dev/ci/docker_linux/docker_push.sh b/dev/ci/docker_linux/docker_push.sh
@@ -5,5 +5,8 @@
 
 TAG="${CIRRUS_TAG:-latest}"
 
-sudo docker push "gcr.io/flutter-cirrus/build-flutter-image:$TAG"
+# Convert "+" to "-" to make hotfix tags legal Docker tag names.
+# See https://docs.docker.com/engine/reference/commandline/tag/
+TAG=${TAG/+/-}
 
+sudo docker push "gcr.io/flutter-cirrus/build-flutter-image:$TAG"
