TODO Audits - 1 (flutter#53604)

Piinks · web-flow · commit 560c72287b17 · 2020-03-31T11:21:01.000-07:00
diff --git a/dev/benchmarks/complex_layout/android/app/build.gradle b/dev/benchmarks/complex_layout/android/app/build.gradle
@@ -39,14 +39,6 @@ android {
             signingConfig signingConfigs.debug
         }
     }
-
-    aaptOptions {
-        // TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
-        if(System.getenv("FLUTTER_CI_WIN")) {
-            println "AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
-            cruncherEnabled false
-        }
-    }
 }
 
 flutter {
diff --git a/dev/benchmarks/platform_views_layout/android/app/build.gradle b/dev/benchmarks/platform_views_layout/android/app/build.gradle
@@ -39,14 +39,6 @@ android {
             signingConfig signingConfigs.debug
         }
     }
-
-    aaptOptions {
-        // TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
-        if(System.getenv("FLUTTER_CI_WIN")) {
-            println "AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
-            cruncherEnabled false
-        }
-    }
 }
 
 flutter {
diff --git a/dev/benchmarks/test_apps/stocks/lib/stock_data.dart b/dev/benchmarks/test_apps/stocks/lib/stock_data.dart
@@ -19,7 +19,7 @@ class Stock {
   Stock(this.symbol, this.name, this.lastSale, this.marketCap, this.percentChange);
 
   Stock.fromFields(List<String> fields) {
-    // FIXME: This class should only have static data, not lastSale, etc.
+    // TODO(jackson): This class should only have static data, not lastSale, etc.
     // "Symbol","Name","LastSale","MarketCap","IPOyear","Sector","industry","Summary Quote",
     lastSale = 0.0;
     try {
diff --git a/dev/devicelab/lib/framework/framework.dart b/dev/devicelab/lib/framework/framework.dart
@@ -97,7 +97,6 @@ class _TaskRunner {
       for (final RunningProcessInfo info in afterRunningDartInstances) {
         if (!beforeRunningDartInstances.contains(info)) {
           print('$info was leaked by this test.');
-          // TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.
           if (result is TaskResultCheckProcesses) {
             result = TaskResult.failure('This test leaked dart processes');
           }
diff --git a/dev/devicelab/lib/framework/running_processes.dart b/dev/devicelab/lib/framework/running_processes.dart
@@ -27,7 +27,7 @@ class RunningProcessInfo {
 
   @override
   int get hashCode {
-    // TODO(dnfield): Replace this when Object.hashValues lands.
+    // TODO(dnfield): Replace this when Object.hashValues lands, https://github.com/dart-lang/sdk/issues/11617
     int hash = 17;
     if (pid != null) {
       hash = hash * 23 + pid.hashCode;
@@ -88,8 +88,7 @@ Stream<RunningProcessInfo> windowsRunningProcesses(String processName) async* {
       ? '"Get-CimInstance Win32_Process -Filter \\"name=\'$processName\'\\" | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"'
       : '"Get-CimInstance Win32_Process | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"';
   // Unfortunately, there doesn't seem to be a good way to get ProcessManager to
-  // run this. May be a bug in Dart.
-  // TODO(dnfield): fix this when https://github.com/dart-lang/sdk/issues/36175 is resolved.
+  // run this.
   final ProcessResult result = await Process.run(
     'powershell -command $script',
     <String>[],
diff --git a/dev/devicelab/manifest.yaml b/dev/devicelab/manifest.yaml
@@ -584,7 +584,7 @@ tasks:
     stage: devicelab_ios
     required_agent_capabilities: ["mac/ios"]
 
-  # TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/41133
+  # TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/43029
   # system_debug_ios:
   #   description: >
   #     Tests that the Engine correctly initializes the system debugger for debug-mode iOS apps.

Original file line number	Diff line number	Diff line change
`@@ -39,14 +39,6 @@ android {`
`39`	`39`	`signingConfig signingConfigs.debug`
`40`	`40`	`}`
`41`	`41`	`}`
`42`		`-`
`43`		`- aaptOptions {`
`44`		`- // TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.`
`45`		`- if(System.getenv("FLUTTER_CI_WIN")) {`
`46`		`- println "AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"`
`47`		`- cruncherEnabled false`
`48`		`- }`
`49`		`- }`
`50`	`42`	`}`
`51`	`43`
`52`	`44`	`flutter {`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ class _TaskRunner {`
`97`	`97`	`for (final RunningProcessInfo info in afterRunningDartInstances) {`
`98`	`98`	`if (!beforeRunningDartInstances.contains(info)) {`
`99`	`99`	`print('$info was leaked by this test.');`
`100`		`- // TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.`
`101`	`100`	`if (result is TaskResultCheckProcesses) {`
`102`	`101`	`result = TaskResult.failure('This test leaked dart processes');`
`103`	`102`	`}`