Update editing state in InputConnectionAdaptor.setSelection (flutter#17652)

jason-simmons · web-flow · commit beb8a7ec48f6 · 2020-04-11T17:29:50.000-07:00
The BaseInputConnection superclass does not call endBatchEdit
in setSelection and therefore does not implicitly cause
InputConnectionAdaptor to send a state update.

Some input modes such as numeric keypads will not function without
these updates.
diff --git a/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java b/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java
@@ -287,6 +287,7 @@ private boolean isSamsung() {
   public boolean setSelection(int start, int end) {
     boolean result = super.setSelection(start, end);
     markDirty();
+    updateEditingState();
     return result;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -287,6 +287,7 @@ private boolean isSamsung() {`
`287`	`287`	`public boolean setSelection(int start, int end) {`
`288`	`288`	`boolean result = super.setSelection(start, end);`
`289`	`289`	`markDirty();`
	`290`	`+ updateEditingState();`
`290`	`291`	`return result;`
`291`	`292`	`}`
`292`	`293`