fix issue with multiple java runtimes on macOS (flutter#52474)

Mubarak Imam · web-flow · commit df90bb5fd64e · 2020-03-31T11:36:01.000-07:00
diff --git a/packages/flutter_tools/lib/src/android/android_sdk.dart b/packages/flutter_tools/lib/src/android/android_sdk.dart
@@ -583,14 +583,13 @@ class AndroidSdk {
     if (platform.isMacOS) {
       try {
         final String javaHomeOutput = processUtils.runSync(
-          <String>['/usr/libexec/java_home'],
+          <String>['/usr/libexec/java_home', '-v', '1.8'],
           throwOnError: true,
           hideStdout: true,
         ).stdout.trim();
         if (javaHomeOutput != null) {
-          final List<String> javaHomeOutputSplit = javaHomeOutput.split('\n');
-          if ((javaHomeOutputSplit != null) && (javaHomeOutputSplit.isNotEmpty)) {
-            final String javaHome = javaHomeOutputSplit[0].trim();
+          if ((javaHomeOutput != null) && (javaHomeOutput.isNotEmpty)) {
+            final String javaHome = javaHomeOutput.split('\n').last.trim();
             return fileSystem.path.join(javaHome, 'bin', 'java');
           }
         }
diff --git a/packages/flutter_tools/test/general.shard/android/android_sdk_test.dart b/packages/flutter_tools/test/general.shard/android/android_sdk_test.dart
@@ -98,7 +98,7 @@ void main() {
           .thenReturn(ProcessResult(1, 0, '26.1.1\n', ''));
       if (globals.platform.isMacOS) {
         when(globals.processManager.runSync(
-          <String>['/usr/libexec/java_home'],
+          <String>['/usr/libexec/java_home', '-v', '1.8'],
           workingDirectory: anyNamed('workingDirectory'),
           environment: anyNamed('environment'),
         )).thenReturn(ProcessResult(0, 0, '', ''));
@@ -137,7 +137,7 @@ void main() {
           .thenReturn(ProcessResult(1, 1, '26.1.1\n', 'Mystery error'));
       if (globals.platform.isMacOS) {
         when(globals.processManager.runSync(
-          <String>['/usr/libexec/java_home'],
+          <String>['/usr/libexec/java_home', '-v', '1.8'],
           workingDirectory: anyNamed('workingDirectory'),
           environment: anyNamed('environment'),
         )).thenReturn(ProcessResult(0, 0, '', ''));
