Drops detached message until we can handle it properly (flutter#45430)

chunhtai · web-flow · commit f15f69a8b8d8 · 2019-11-22T16:10:46.000-08:00
diff --git a/packages/flutter/lib/src/scheduler/binding.dart b/packages/flutter/lib/src/scheduler/binding.dart
@@ -338,6 +338,11 @@ mixin SchedulerBinding on BindingBase, ServicesBinding {
   }
 
   Future<String> _handleLifecycleMessage(String message) async {
+    // TODO(chunhtai): remove the workaround once the issue is fixed
+    // https://github.com/flutter/flutter/issues/39832
+    if (message == 'AppLifecycleState.detached')
+      return null;
+
     handleAppLifecycleStateChanged(_parseAppLifecycleMessage(message));
     return null;
   }
diff --git a/packages/flutter/test/widgets/binding_test.dart b/packages/flutter/test/widgets/binding_test.dart
@@ -67,6 +67,14 @@ void main() {
     message = const StringCodec().encodeMessage('AppLifecycleState.inactive');
     await defaultBinaryMessenger.handlePlatformMessage('flutter/lifecycle', message, (_) { });
     expect(observer.lifecycleState, AppLifecycleState.inactive);
+
+
+    message = const StringCodec().encodeMessage('AppLifecycleState.detached');
+    await defaultBinaryMessenger.handlePlatformMessage('flutter/lifecycle', message, (_) { });
+    // TODO(chunhtai): this should be detached once the issue is fixed
+    // https://github.com/flutter/flutter/issues/39832
+    // The binding drops detached message for now.
+    expect(observer.lifecycleState, AppLifecycleState.inactive);
   });
 
   testWidgets('didPushRoute callback', (WidgetTester tester) async {

Original file line number	Diff line number	Diff line change
`@@ -338,6 +338,11 @@ mixin SchedulerBinding on BindingBase, ServicesBinding {`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`Future<String> _handleLifecycleMessage(String message) async {`
	`341`	`+ // TODO(chunhtai): remove the workaround once the issue is fixed`
	`342`	`+ // https://github.com/flutter/flutter/issues/39832`
	`343`	`+ if (message == 'AppLifecycleState.detached')`
	`344`	`+ return null;`
	`345`	`+`
`341`	`346`	`handleAppLifecycleStateChanged(_parseAppLifecycleMessage(message));`
`342`	`347`	`return null;`
`343`	`348`	`}`