Skip to content

Commit 0bcad13

Browse files
chrisvfritzyyx990803
authored andcommitted
Reorganize and update PR template (vuejs#5106)
* Reorganize and update PR template * Update PULL_REQUEST_TEMPLATE.md * Remove required info for bugfixes
1 parent e12d96a commit 0bcad13

File tree

1 file changed

+30
-35
lines changed

1 file changed

+30
-35
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 30 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -3,38 +3,33 @@ Please make sure to read the Pull Request Guidelines:
33
https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines
44
-->
55

6-
<!-- ISSUE TEMPLATE -->
7-
**Please check if the PR fulfills these requirements**
8-
- [ ] Do not submit PRs against the master branch.
9-
- [ ] Checkout a topic branch from the relevant branch, e.g. dev, and merge back against that branch.
10-
- [ ] The tests are running: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
11-
12-
If adding new feature:
13-
- [ ] Added accompanying test case.
14-
- [ ] In the commit message, provide convincing reason to add this feature.
15-
Ideally you should open a suggestion issue first and have it greenlighted before working on it.
16-
17-
If fixing a bug:
18-
- [ ] If you are resolving a special issue, add (fix #xxxx[,#xxx]) (#xxxx is the issue id) in your PR title
19-
- [ ] Provide detailed description of the bug in the PR. Live demo preferred.
20-
- [ ] Add appropriate test coverage if applicable.
21-
22-
**What kind of change does this PR introduce?** (check at least one with "x")
23-
```
24-
[ ] Bugfix
25-
[ ] Feature
26-
[ ] Code style update
27-
[ ] Refactoring
28-
[ ] Build related changes
29-
[ ] Other... Please describe:
30-
```
31-
32-
**Does this PR introduce a breaking change?** (check one with "x")
33-
```
34-
[ ] Yes
35-
[ ] No
36-
```
37-
38-
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
39-
40-
**Other information**:
6+
<!-- PULL REQUEST TEMPLATE -->
7+
<!-- (Update "[ ]" to "[x]" to check a box) -->
8+
9+
**What kind of change does this PR introduce?** (check at least one)
10+
11+
- [ ] Bugfix
12+
- [ ] Feature
13+
- [ ] Code style update
14+
- [ ] Refactor
15+
- [ ] Build-related changes
16+
- [ ] Other, please describe:
17+
18+
**Does this PR introduce a breaking change?** (check one)
19+
20+
- [ ] Yes
21+
- [ ] No
22+
23+
If yes, please describe the impact and migration path for existing applications:
24+
25+
**The PR fulfills these requirements:**
26+
27+
- [ ] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch
28+
- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number)
29+
- [ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
30+
- [ ] New/updated tests are included
31+
32+
If adding a **new feature**, the PR's description includes:
33+
- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
34+
35+
**Other information:**

0 commit comments

Comments
 (0)