fix special static attrs as dom prop

defcc · defcc · commit e3d7a03617d2 · 2017-01-06T00:42:01.000+08:00
diff --git a/flow/compiler.js b/flow/compiler.js
@@ -75,6 +75,7 @@ declare type ASTElement = {
   staticInFor?: boolean;
   staticProcessed?: boolean;
   hasBindings?: boolean;
+  hasNormalProp?: true;
 
   text?: string;
   attrs?: Array<{ name: string; value: string }>;
diff --git a/src/compiler/optimizer.js b/src/compiler/optimizer.js
@@ -1,6 +1,6 @@
 /* @flow */
 
-import { makeMap, isBuiltInTag, cached, no } from 'shared/util'
+import { makeMap, isBuiltInTag, cached, no, remove } from 'shared/util'
 
 let isStaticKey
 let isPlatformReservedTag
@@ -99,13 +99,17 @@ function isStatic (node: ASTNode): boolean {
   if (node.type === 3) { // text
     return true
   }
+  const nodeAttrs = Object.keys(node)
+  if (!node.hasNormalProp && node.props && node.props.length) {
+    remove(nodeAttrs, 'props')
+  }
   return !!(node.pre || (
     !node.hasBindings && // no dynamic bindings
     !node.if && !node.for && // not v-if or v-for or v-else
     !isBuiltInTag(node.tag) && // not a built-in
     isPlatformReservedTag(node.tag) && // not a component
     !isDirectChildOfTemplateFor(node) &&
-    Object.keys(node).every(isStaticKey)
+    nodeAttrs.every(isStaticKey)
   ))
 }
 
diff --git a/src/compiler/parser/index.js b/src/compiler/parser/index.js
@@ -444,6 +444,7 @@ function processAttrs (el) {
           }
         }
         if (isProp || platformMustUseProp(el.tag, name)) {
+          el.hasNormalProp = true
           addProp(el, name, value)
         } else {
           addAttr(el, name, value)
diff --git a/test/unit/modules/compiler/optimizer.spec.js b/test/unit/modules/compiler/optimizer.spec.js
@@ -191,6 +191,12 @@ describe('optimizer', () => {
     expect(ast.children[0].static).toBe(false)
   })
 
+  it('mark static with static dom property', () => {
+    const ast = parse('<input type="text" value="1">', baseOptions)
+    optimize(ast, baseOptions)
+    expect(ast.static).toBe(true)
+  })
+
   it('not root ast', () => {
     const ast = null
     optimize(ast, baseOptions)

Original file line number	Diff line number	Diff line change
`@@ -444,6 +444,7 @@ function processAttrs (el) {`
`444`	`444`	`}`
`445`	`445`	`}`
`446`	`446`	`if (isProp \|\| platformMustUseProp(el.tag, name)) {`
	`447`	`+ el.hasNormalProp = true`
`447`	`448`	`addProp(el, name, value)`
`448`	`449`	`} else {`
`449`	`450`	`addAttr(el, name, value)`