signal_impl::clear(): Really avoid erasing the slots prematurely

Kjell Ahlstedt · Kjell Ahlstedt · commit abf29c46861d · 2016-12-08T13:33:11.000+01:00
The call signal_impl_exec_holder(this) creates a signal_impl_exec_holder
which is immediately destroyed. It does not stop signal_impl::notify() from
erasing the slots. Create a signal_impl_exec_holder that exists until the
end of clear().
diff --git a/sigc++/signal_base.cc b/sigc++/signal_base.cc
@@ -65,7 +65,7 @@ signal_impl::clear()
   // Don't let signal_impl::notify() erase the slots. It would invalidate the
   // iterator in the following loop.
   const bool saved_deferred = deferred_;
-  signal_impl_exec_holder(this);
+  signal_impl_exec_holder exec(this);
 
   // Disconnect all connected slots before they are deleted.
   // signal_impl::notify() will be called and delete the self_and_iter structs.
