Fix hyphen in requirement didn't work with bzlmod (bazel-contrib#952) (bazel-contrib#957)

acr92 · web-flow · commit 2c29f401dcab · 2022-12-31T07:26:14.000+11:00
diff --git a/examples/bzlmod/BUILD.bazel b/examples/bzlmod/BUILD.bazel
@@ -16,6 +16,7 @@ py_library(
     deps = [
         requirement("pylint"),
         requirement("tabulate"),
+        requirement("python-dateutil"),
     ],
 )
 
diff --git a/examples/bzlmod/requirements.in b/examples/bzlmod/requirements.in
@@ -3,3 +3,4 @@ s3cmd~=2.1.0
 yamllint>=1.28.0
 tabulate~=0.9.0
 pylint~=2.15.5
+python-dateutil>=2.8.2
diff --git a/examples/bzlmod/requirements_lock.txt b/examples/bzlmod/requirements_lock.txt
@@ -68,7 +68,9 @@ pylint==2.15.9 \
 python-dateutil==2.8.2 \
     --hash=sha256:0123cacc1627ae19ddf3c27a5de5bd67ee4586fbdd6440d9748f8abb483d3e86 \
     --hash=sha256:961d03dc3453ebbc59dbdea9e4e11c5651520a876d0f4db161e8674aae935da9
-    # via s3cmd
+    # via
+    #   -r ./requirements.in
+    #   s3cmd
 python-magic==0.4.27 \
     --hash=sha256:c1ba14b08e4a5f5c31a302b7721239695b2f0f058d125bd5ce1ee36b9d9d3c3b \
     --hash=sha256:c212960ad306f700aa0d01e5d7a325d20548ff97eb9920dcd29513174f0294d3
diff --git a/examples/bzlmod/requirements_windows.txt b/examples/bzlmod/requirements_windows.txt
@@ -72,7 +72,9 @@ pylint==2.15.9 \
 python-dateutil==2.8.2 \
     --hash=sha256:0123cacc1627ae19ddf3c27a5de5bd67ee4586fbdd6440d9748f8abb483d3e86 \
     --hash=sha256:961d03dc3453ebbc59dbdea9e4e11c5651520a876d0f4db161e8674aae935da9
-    # via s3cmd
+    # via
+    #   -r ./requirements.in
+    #   s3cmd
 python-magic==0.4.27 \
     --hash=sha256:c1ba14b08e4a5f5c31a302b7721239695b2f0f058d125bd5ce1ee36b9d9d3c3b \
     --hash=sha256:c212960ad306f700aa0d01e5d7a325d20548ff97eb9920dcd29513174f0294d3
diff --git a/python/pip_install/pip_repository.bzl b/python/pip_install/pip_repository.bzl
@@ -287,7 +287,11 @@ alias(
     name = "{name}_dist_info",
     actual = "@{repo_prefix}{dep}//:dist_info",
 )
-""".format(name = _clean_pkg_name(requirement[0]), repo_prefix = rctx.attr.repo_prefix, dep = requirement[0])
+""".format(
+            name = _clean_pkg_name(requirement[0]),
+            repo_prefix = rctx.attr.repo_prefix,
+            dep = _clean_pkg_name(requirement[0]),
+        )
 
     return build_content
 

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ py_library(`
`16`	`16`	`deps = [`
`17`	`17`	`requirement("pylint"),`
`18`	`18`	`requirement("tabulate"),`
	`19`	`+ requirement("python-dateutil"),`
`19`	`20`	`],`
`20`	`21`	`)`
`21`	`22`