Remove confusing conditions (brianc#1159)

charmander · brianc · commit 981960b445c0 · 2016-12-13T07:50:07.000-06:00
* Remove unreachable code

* Remove redundant condition

Every path with `!this.values` results in `false` regardless of `this.binary`.
diff --git a/lib/query.js b/lib/query.js
@@ -65,11 +65,9 @@ Query.prototype.requiresPreparation = function() {
   if(this.rows) { return true; }
   //don't prepare empty text queries
   if(!this.text) { return false; }
-  //binary should be prepared to specify results should be in binary
-  //unless there are no parameters
-  if(this.binary && !this.values) { return false; }
   //prepare if there are values
-  return (this.values || 0).length > 0;
+  if(!this.values) { return false; }
+  return this.values.length > 0;
 };
 
 
diff --git a/lib/utils.js b/lib/utils.js
@@ -64,9 +64,6 @@ var prepareValue = function(val, seen) {
   if(typeof val === 'object') {
     return prepareObject(val, seen);
   }
-  if (typeof val === 'undefined') {
-    throw new Error('SQL queries with undefined where clause option');
-  }
   return val.toString();
 };
 

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,6 @@ var prepareValue = function(val, seen) {`
`64`	`64`	`if(typeof val === 'object') {`
`65`	`65`	`return prepareObject(val, seen);`
`66`	`66`	`}`
`67`		`- if (typeof val === 'undefined') {`
`68`		`- throw new Error('SQL queries with undefined where clause option');`
`69`		`- }`
`70`	`67`	`return val.toString();`
`71`	`68`	`};`
`72`	`69`