Refine asserts

zxw1962 · zxw1962 · commit d0ce4033f728 · 2014-08-18T19:18:19.000+08:00
diff --git a/library/src/main/java/com/loopj/android/http/AssertUtils.java b/library/src/main/java/com/loopj/android/http/AssertUtils.java
@@ -0,0 +1,34 @@
+/*
+    Android Asynchronous Http Client
+    Copyright (c) 2011 James Smith <james@loopj.com>
+    http://loopj.com
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+        http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+*/
+
+package com.loopj.android.http;
+
+/**
+ * Internal class, used to make some asserts, throw AssertError if asserts fail.
+ */
+class AssertUtils {
+
+    private AssertUtils() {
+    }
+
+    public static void asserts(final boolean expression, final String failedMessage) {
+        if (!expression) {
+            throw new AssertionError(failedMessage);
+        }
+    }
+}
diff --git a/library/src/main/java/com/loopj/android/http/AsyncHttpResponseHandler.java b/library/src/main/java/com/loopj/android/http/AsyncHttpResponseHandler.java
@@ -357,7 +357,7 @@ protected void sendMessage(Message msg) {
         if (getUseSynchronousMode() || handler == null) {
             handleMessage(msg);
         } else if (!Thread.currentThread().isInterrupted()) { // do not send messages if request has been cancelled
-            assert handler != null;
+            AssertUtils.asserts(handler != null, "handler should not be null!");
             handler.sendMessage(msg);
         }
     }
@@ -374,7 +374,7 @@ protected void postRunnable(Runnable runnable) {
                 runnable.run();
             } else {
                 // Otherwise, run on provided handler
-                assert handler != null;
+                AssertUtils.asserts(handler != null, "handler should not be null!");
                 handler.post(runnable);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ protected void sendMessage(Message msg) {`
`357`	`357`	`if (getUseSynchronousMode() \|\| handler == null) {`
`358`	`358`	`handleMessage(msg);`
`359`	`359`	`} else if (!Thread.currentThread().isInterrupted()) { // do not send messages if request has been cancelled`
`360`		`- assert handler != null;`
	`360`	`+ AssertUtils.asserts(handler != null, "handler should not be null!");`
`361`	`361`	`handler.sendMessage(msg);`
`362`	`362`	`}`
`363`	`363`	`}`
`@@ -374,7 +374,7 @@ protected void postRunnable(Runnable runnable) {`
`374`	`374`	`runnable.run();`
`375`	`375`	`} else {`
`376`	`376`	`// Otherwise, run on provided handler`
`377`		`- assert handler != null;`
	`377`	`+ AssertUtils.asserts(handler != null, "handler should not be null!");`
`378`	`378`	`handler.post(runnable);`
`379`	`379`	`}`
`380`	`380`	`}`