[WIP] Introduce CommitFilter.Parse()

nulltoken · nulltoken · commit a289bbf9cad8 · 2015-10-25T09:49:45.000+01:00
diff --git a/LibGit2Sharp.Tests/CommitFilterFixture.cs b/LibGit2Sharp.Tests/CommitFilterFixture.cs
@@ -0,0 +1,29 @@
+using System;
+using LibGit2Sharp.Tests.TestHelpers;
+using Xunit;
+using Xunit.Extensions;
+
+namespace LibGit2Sharp.Tests
+{
+    public class CommitFilterFixture : BaseFixture
+    {
+        [Theory]
+        [InlineData("HEAD^", "HEAD^", null)]
+        [InlineData("HEAD^..HEAD", "HEAD", "HEAD^")]
+        [InlineData("HEAD^..", null, "HEAD^")]
+        public void tada(string expression, object includeReachableFrom, object excludeReachableFrom)
+        {
+            CommitFilter cf = CommitFilter.Parse(expression);
+
+            Assert.Equal(includeReachableFrom, cf.IncludeReachableFrom);
+            Assert.Equal(excludeReachableFrom, cf.ExcludeReachableFrom);
+        }
+
+        [Fact]
+        public void throws()
+        {
+            Assert.Throws<ArgumentException>(() => CommitFilter.Parse(""));
+            Assert.Throws<ArgumentNullException>(() => CommitFilter.Parse(default(string)));
+        }
+    }
+}
diff --git a/LibGit2Sharp.Tests/LibGit2Sharp.Tests.csproj b/LibGit2Sharp.Tests/LibGit2Sharp.Tests.csproj
@@ -60,6 +60,7 @@
     <Compile Include="ArchiveTarFixture.cs" />
     <Compile Include="CheckoutFixture.cs" />
     <Compile Include="CherryPickFixture.cs" />
+    <Compile Include="CommitFilterFixture.cs" />
     <Compile Include="DescribeFixture.cs" />
     <Compile Include="FileHistoryFixture.cs" />
     <Compile Include="FilterFixture.cs" />
diff --git a/LibGit2Sharp/CommitFilter.cs b/LibGit2Sharp/CommitFilter.cs
@@ -1,7 +1,9 @@
 ﻿using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
+using LibGit2Sharp.Core;
 
 namespace LibGit2Sharp
 {
@@ -121,5 +123,43 @@ private static IList<object> ToList(object obj)
             list.AddRange(((IEnumerable)obj).Cast<object>());
             return list;
         }
+
+        public static CommitFilter Parse(string expression)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(expression, "expression");
+
+            if (expression.Contains(" "))
+            {
+                throw new NotSupportedException();
+            }
+
+            if (expression.Contains("..."))
+            {
+                return MergeRangeParse(expression);
+            }
+
+            if (expression.Contains(".."))
+            {
+                return RangeParse(expression);
+            }
+
+            return new CommitFilter { IncludeReachableFrom = expression };
+        }
+
+        private static CommitFilter MergeRangeParse(string expression)
+        {
+            throw new NotImplementedException();
+        }
+
+        private static CommitFilter RangeParse(string expression)
+        {
+            var parts = expression.Split(new[] { ".." }, StringSplitOptions.None);
+
+            Debug.Assert(parts.Length == 2);
+
+            Func<string, string> nullify = (s) => s == string.Empty ? null : s;
+
+            return new CommitFilter { IncludeReachableFrom = nullify(parts[1]), ExcludeReachableFrom = nullify(parts[0]) };
+        }
     }
 }
