Obsolete NoteCollection.Add() overload that do not require Signature parameters

nulltoken · nulltoken · commit a6874715646d · 2015-08-18T11:23:20.000+02:00
diff --git a/LibGit2Sharp.Tests/NoteFixture.cs b/LibGit2Sharp.Tests/NoteFixture.cs
@@ -175,7 +175,10 @@ public void CanAddANoteWithSignatureFromConfig()
             using (var repo = new Repository(path, options))
             {
                 var commit = repo.Lookup<Commit>("9fd738e8f7967c078dceed8190330fc8648ee56a");
-                var note = repo.Notes.Add(commit.Id, "I'm batman!\n", "batmobile");
+
+                Signature signature = repo.Config.BuildSignature(DateTimeOffset.Now);
+
+                var note = repo.Notes.Add(commit.Id, "I'm batman!\n", signature, signature, "batmobile");
 
                 var newNote = commit.Notes.Single();
                 Assert.Equal(note, newNote);
diff --git a/LibGit2Sharp/NoteCollection.cs b/LibGit2Sharp/NoteCollection.cs
@@ -171,6 +171,7 @@ internal static string UnCanonicalizeName(string name)
         /// <param name="message">The note message.</param>
         /// <param name="namespace">The namespace on which the note will be created. It can be either a canonical namespace or an abbreviated namespace ('refs/notes/myNamespace' or just 'myNamespace').</param>
         /// <returns>The note which was just saved.</returns>
+        [Obsolete("This method will be removed in the next release. Please use Add(ObjectId, string, Signature, Signature, string) instead.")]
         public virtual Note Add(ObjectId targetId, string message, string @namespace)
         {
             Signature author = repo.Config.BuildSignatureOrThrow(DateTimeOffset.Now);

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,7 @@ internal static string UnCanonicalizeName(string name)`
`171`	`171`	`/// <param name="message">The note message.</param>`
`172`	`172`	`/// <param name="namespace">The namespace on which the note will be created. It can be either a canonical namespace or an abbreviated namespace ('refs/notes/myNamespace' or just 'myNamespace').</param>`
`173`	`173`	`/// <returns>The note which was just saved.</returns>`
	`174`	`+ [Obsolete("This method will be removed in the next release. Please use Add(ObjectId, string, Signature, Signature, string) instead.")]`
`174`	`175`	`public virtual Note Add(ObjectId targetId, string message, string @namespace)`
`175`	`176`	`{`
`176`	`177`	`Signature author = repo.Config.BuildSignatureOrThrow(DateTimeOffset.Now);`