reverting RBAC changes; not relevant here

dannykopping · dannykopping · commit 2c2554206394 · 2025-03-13T19:56:26.000Z
appeasing linter

Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -18,7 +18,6 @@ import (
 
 	"cdr.dev/slog"
 
-	"github.com/coder/coder/v2/coderd/prebuilds"
 	"github.com/coder/coder/v2/coderd/rbac/policy"
 	"github.com/coder/coder/v2/coderd/rbac/rolestore"
 
@@ -359,27 +358,6 @@ var (
 		}),
 		Scope: rbac.ScopeAll,
 	}.WithCachedASTValue()
-
-	subjectPrebuildsOrchestrator = rbac.Subject{
-		FriendlyName: "Prebuilds Orchestrator",
-		ID:           prebuilds.OwnerID.String(),
-		Roles: rbac.Roles([]rbac.Role{
-			{
-				Identifier:  rbac.RoleIdentifier{Name: "prebuilds-orchestrator"},
-				DisplayName: "Coder",
-				Site: rbac.Permissions(map[string][]policy.Action{
-					// May use template, read template-related info, & insert template-related resources (preset prebuilds).
-					rbac.ResourceTemplate.Type: {policy.ActionRead, policy.ActionUpdate, policy.ActionUse},
-					// May CRUD workspaces, and start/stop them.
-					rbac.ResourceWorkspace.Type: {
-						policy.ActionCreate, policy.ActionDelete, policy.ActionRead, policy.ActionUpdate,
-						policy.ActionWorkspaceStart, policy.ActionWorkspaceStop,
-					},
-				}),
-			},
-		}),
-		Scope: rbac.ScopeAll,
-	}.WithCachedASTValue()
 )
 
 // AsProvisionerd returns a context with an actor that has permissions required
@@ -434,12 +412,6 @@ func AsSystemReadProvisionerDaemons(ctx context.Context) context.Context {
 	return context.WithValue(ctx, authContextKey{}, subjectSystemReadProvisionerDaemons)
 }
 
-// AsPrebuildsOrchestrator returns a context with an actor that has permissions
-// to read orchestrator workspace prebuilds.
-func AsPrebuildsOrchestrator(ctx context.Context) context.Context {
-	return context.WithValue(ctx, authContextKey{}, subjectPrebuildsOrchestrator)
-}
-
 var AsRemoveActor = rbac.Subject{
 	ID: "remove-actor",
 }
diff --git a/coderd/users_test.go b/coderd/users_test.go
@@ -2428,7 +2428,7 @@ func TestSystemUserBehaviour(t *testing.T) {
 	sqlDB := testSQLDB(t)
 	err := migrations.Up(sqlDB) // coderd/database/migrations/00030*_system_user.up.sql will create a system user.
 	require.NoError(t, err, "migrations")
-	
+
 	db := database.New(sqlDB)
 
 	// =================================================================================================================
@@ -2488,7 +2488,7 @@ func TestSystemUserBehaviour(t *testing.T) {
 
 	// When: attempting to update a user's roles.
 	_, err = db.UpdateUserRoles(ctx, database.UpdateUserRolesParams{
-		ID: systemUser.ID,
+		ID:           systemUser.ID,
 		GrantedRoles: []string{rbac.RoleAuditor().String()},
 	})
 	// Then: the attempt is rejected by a postgres trigger.
