fix(coderd): check if timings can be read (coder#14697)

BrunoQuaresma · web-flow · commit 370f0b90204e · 2024-09-17T10:57:57.000-03:00
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
@@ -1792,6 +1792,10 @@ func (q *querier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (data
 }
 
 func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) {
+	_, err := q.GetProvisionerJobByID(ctx, jobID)
+	if err != nil {
+		return nil, err
+	}
 	return q.db.GetProvisionerJobTimingsByJobID(ctx, jobID)
 }
 
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
@@ -552,10 +552,13 @@ func (s *MethodTestSuite) TestProvisionerJob() {
 			Asserts(v.RBACObject(tpl), []policy.Action{policy.ActionRead, policy.ActionUpdate}).Returns()
 	}))
 	s.Run("GetProvisionerJobTimingsByJobID", s.Subtest(func(db database.Store, check *expects) {
-		jobID := uuid.New()
-		j := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{ID: jobID})
+		w := dbgen.Workspace(s.T(), db, database.Workspace{})
+		j := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{
+			Type: database.ProvisionerJobTypeWorkspaceBuild,
+		})
+		_ = dbgen.WorkspaceBuild(s.T(), db, database.WorkspaceBuild{JobID: j.ID, WorkspaceID: w.ID})
 		t := dbgen.ProvisionerJobTimings(s.T(), db, database.InsertProvisionerJobTimingsParams{
-			JobID:     jobID,
+			JobID:     j.ID,
 			StartedAt: []time.Time{dbtime.Now(), dbtime.Now()},
 			EndedAt:   []time.Time{dbtime.Now(), dbtime.Now()},
 			Stage: []database.ProvisionerJobTimingStage{
@@ -566,7 +569,7 @@ func (s *MethodTestSuite) TestProvisionerJob() {
 			Action:   []string{"action1", "action2"},
 			Resource: []string{"resource1", "resource2"},
 		})
-		check.Args(j.ID).Asserts().Returns(t)
+		check.Args(j.ID).Asserts(w, policy.ActionRead).Returns(t)
 	}))
 	s.Run("GetProvisionerJobsByIDs", s.Subtest(func(db database.Store, check *expects) {
 		a := dbgen.ProvisionerJob(s.T(), db, nil, database.ProvisionerJob{})

Original file line number	Diff line number	Diff line change
`@@ -1792,6 +1792,10 @@ func (q *querier) GetProvisionerJobByID(ctx context.Context, id uuid.UUID) (data`
`1792`	`1792`	`}`
`1793`	`1793`
`1794`	`1794`	`func (q *querier) GetProvisionerJobTimingsByJobID(ctx context.Context, jobID uuid.UUID) ([]database.ProvisionerJobTiming, error) {`
	`1795`	`+ _, err := q.GetProvisionerJobByID(ctx, jobID)`
	`1796`	`+ if err != nil {`
	`1797`	`+ return nil, err`
	`1798`	`+ }`
`1795`	`1799`	`return q.db.GetProvisionerJobTimingsByJobID(ctx, jobID)`
`1796`	`1800`	`}`
`1797`	`1801`