chore(cli): wait for agent to connect before dialing it in TestExpRpty (coder#17026)

johnstcn · web-flow · commit 3bd32a2e2a7f · 2025-03-20T14:44:30.000Z
Fixes flake seen here: https://github.com/coder/coder/actions/runs/13970861685/job/39113344525
diff --git a/cli/exp_rpty_test.go b/cli/exp_rpty_test.go
@@ -33,14 +33,14 @@ func TestExpRpty(t *testing.T) {
 
 		ctx := testutil.Context(t, testutil.WaitLong)
 
+		_ = agenttest.New(t, client.URL, agentToken)
+		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
+
 		cmdDone := tGo(t, func() {
 			err := inv.WithContext(ctx).Run()
 			assert.NoError(t, err)
 		})
 
-		_ = agenttest.New(t, client.URL, agentToken)
-		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
-
 		pty.WriteLine("exit")
 		<-cmdDone
 	})
@@ -56,14 +56,14 @@ func TestExpRpty(t *testing.T) {
 
 		ctx := testutil.Context(t, testutil.WaitLong)
 
+		_ = agenttest.New(t, client.URL, agentToken)
+		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
+
 		cmdDone := tGo(t, func() {
 			err := inv.WithContext(ctx).Run()
 			assert.NoError(t, err)
 		})
 
-		_ = agenttest.New(t, client.URL, agentToken)
-		_ = coderdtest.NewWorkspaceAgentWaiter(t, client, workspace.ID).Wait()
-
 		pty.ExpectMatch(randStr)
 		<-cmdDone
 	})
