fix(vpn): pass dup'd FDs to tunnel (coder#16249)

ethanndickson · web-flow · commit 4872d14e5525 · 2025-01-24T02:29:20.000Z
We were duping the passed FDs and then not using the result.
diff --git a/vpn/dylib/lib.go b/vpn/dylib/lib.go
@@ -39,7 +39,7 @@ func OpenTunnel(cReadFD, cWriteFD int32) int32 {
 		return ErrDupWriteFD
 	}
 
-	conn, err := vpn.NewBidirectionalPipe(uintptr(cReadFD), uintptr(cWriteFD))
+	conn, err := vpn.NewBidirectionalPipe(uintptr(readFD), uintptr(writeFD))
 	if err != nil {
 		unix.Close(readFD)
 		unix.Close(writeFD)

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func OpenTunnel(cReadFD, cWriteFD int32) int32 {`
`39`	`39`	`return ErrDupWriteFD`
`40`	`40`	`}`
`41`	`41`
`42`		`- conn, err := vpn.NewBidirectionalPipe(uintptr(cReadFD), uintptr(cWriteFD))`
	`42`	`+ conn, err := vpn.NewBidirectionalPipe(uintptr(readFD), uintptr(writeFD))`
`43`	`43`	`if err != nil {`
`44`	`44`	`unix.Close(readFD)`
`45`	`45`	`unix.Close(writeFD)`