fix: add better error handling

Parkreiner · Parkreiner · commit 50f6a70cc178 · 2025-02-25T03:51:49.000Z
diff --git a/site/src/modules/resources/AgentMetadata.tsx b/site/src/modules/resources/AgentMetadata.tsx
@@ -83,7 +83,9 @@ export const AgentMetadata: FC<AgentMetadataProps> = ({
 					const data = JSON.parse(e.data);
 					setMetadata(data);
 				} catch {
-					displayError("Unable to process newest response from server");
+					displayError(
+						"Unable to process newest response from server. The UI may be out of date.",
+					);
 				}
 			});
 		};
diff --git a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx
@@ -98,9 +98,6 @@ describe("WorkspacePage", () => {
 			.spyOn(API, "deleteWorkspace")
 			.mockResolvedValueOnce(MockWorkspaceBuild);
 		await renderWorkspacePage(MockWorkspace);
-		new MockServerSocket(
-			`ws://localhost/api/v2/workspaces/${MockWorkspace.id}/watch`,
-		);
 
 		// open the workspace action popover so we have access to all available ctas
 		const trigger = screen.getByTestId("workspace-options-button");
diff --git a/site/src/pages/WorkspacePage/WorkspacePage.tsx b/site/src/pages/WorkspacePage/WorkspacePage.tsx
@@ -15,6 +15,7 @@ import { useQuery, useQueryClient } from "react-query";
 import { useParams } from "react-router-dom";
 import { WorkspaceReadyPage } from "./WorkspaceReadyPage";
 import { type WorkspacePermissions, workspaceChecks } from "./permissions";
+import { displayError } from "components/GlobalSnackbar/utils";
 
 export const WorkspacePage: FC = () => {
 	const queryClient = useQueryClient();
@@ -84,8 +85,14 @@ export const WorkspacePage: FC = () => {
 
 		const socket = watchWorkspace(workspaceId);
 		socket.addEventListener("message", (event) => {
-			const newWorkspaceData = JSON.parse(event.data) as Workspace;
-			void updateWorkspaceData(newWorkspaceData);
+			try {
+				const newWorkspaceData = JSON.parse(event.data) as Workspace;
+				void updateWorkspaceData(newWorkspaceData);
+			} catch {
+				displayError(
+					"Unable to parse latest data from the server. The UI may be out of date.",
+				);
+			}
 		});
 		socket.addEventListener("error", (event) => {
 			console.error("Error on getting workspace changes.", event);
