fix: display all available settings (coder#16798)

mtojek · web-flow · commit 975ea23d6f49 · 2025-03-04T15:46:25.000+01:00
Fixes: coder#15420
diff --git a/site/src/pages/DeploymentSettingsPage/OptionsTable.tsx b/site/src/pages/DeploymentSettingsPage/OptionsTable.tsx
@@ -49,13 +49,6 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {
 				</TableHead>
 				<TableBody>
 					{Object.values(options).map((option) => {
-						if (
-							option.value === null ||
-							option.value === "" ||
-							option.value === undefined
-						) {
-							return null;
-						}
 						return (
 							<TableRow key={option.flag} className={`option-${option.flag}`}>
 								<TableCell>
diff --git a/site/src/pages/DeploymentSettingsPage/optionValue.ts b/site/src/pages/DeploymentSettingsPage/optionValue.ts
@@ -51,6 +51,10 @@ export function optionValue(
 				break;
 			}
 
+			if (!option.value) {
+				return "";
+			}
+
 			// We show all experiments (including unsafe) that are currently enabled on a deployment
 			// but only show safe experiments that are not.
 			// biome-ignore lint/suspicious/noExplicitAny: opt.value is any
@@ -59,7 +63,6 @@ export function optionValue(
 					experimentMap[v] = true;
 				}
 			}
-
 			return experimentMap;
 		}
 		default:

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,10 @@ export function optionValue(`
`51`	`51`	`break;`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ if (!option.value) {`
	`55`	`+ return "";`
	`56`	`+ }`
	`57`	`+`
`54`	`58`	`// We show all experiments (including unsafe) that are currently enabled on a deployment`
`55`	`59`	`// but only show safe experiments that are not.`
`56`	`60`	`// biome-ignore lint/suspicious/noExplicitAny: opt.value is any`
`@@ -59,7 +63,6 @@ export function optionValue(`
`59`	`63`	`experimentMap[v] = true;`
`60`	`64`	`}`
`61`	`65`	`}`
`62`		`-`
`63`	`66`	`return experimentMap;`
`64`	`67`	`}`
`65`	`68`	`default:`