Skip to content

Commit bb69054

Browse files
fix(cli): remove loading indicator when pinging with verbose logs (coder#16305)
This was causing some verbose log lines to be prepended with the spinner message, e.g. ``` ◱ Collecting diagnostics...2025-01-28 10:26:27.502 ``` which doesnt look very good. Presumably anyone running it with verbose will know it takes a moment to collect diagnostics first.
1 parent b44ae40 commit bb69054

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cli/ping.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@ func (r *RootCmd) ping() *serpent.Command {
120120
spin := spinner.New(spinner.CharSets[5], 100*time.Millisecond)
121121
spin.Writer = inv.Stderr
122122
spin.Suffix = pretty.Sprint(cliui.DefaultStyles.Keyword, " Collecting diagnostics...")
123-
spin.Start()
123+
if !r.verbose {
124+
spin.Start()
125+
}
124126

125127
opts := &workspacesdk.DialAgentOptions{}
126128

0 commit comments

Comments
 (0)