fix: update more dependency array bugs

Parkreiner · Parkreiner · commit c466bd04cdd0 · 2025-02-26T13:42:09.000Z
diff --git a/site/src/modules/templates/useWatchVersionLogs.ts b/site/src/modules/templates/useWatchVersionLogs.ts
@@ -15,17 +15,11 @@ export const useWatchVersionLogs = (
 		setLogs(undefined);
 	}
 
-	const templateVersionStatus = templateVersion?.job.status;
 	const stableOnDone = useEffectEvent(() => options?.onDone());
+	const status = templateVersion?.job.status;
+	const canWatch = status === "running" || status === "pending";
 	useEffect(() => {
-		if (!templateVersionId || !templateVersionStatus) {
-			return;
-		}
-
-		if (
-			templateVersionStatus !== "running" &&
-			templateVersionStatus !== "pending"
-		) {
+		if (!templateVersionId || !canWatch) {
 			return;
 		}
 
@@ -40,7 +34,7 @@ export const useWatchVersionLogs = (
 		});
 
 		return () => socket.close();
-	}, [stableOnDone, templateVersionId, templateVersionStatus]);
+	}, [stableOnDone, canWatch, templateVersionId]);
 
 	return logs;
 };
