diff --git a/flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp b/flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp index 7d1f86f8cee94..0cd2858ab5e75 100644 --- a/flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp +++ b/flang/lib/Optimizer/Transforms/SimplifyRegionLite.cpp @@ -26,22 +26,16 @@ class SimplifyRegionLitePass public: void runOnOperation() override; }; - -class DummyRewriter : public mlir::PatternRewriter { -public: - DummyRewriter(mlir::MLIRContext *ctx) : mlir::PatternRewriter(ctx) {} -}; - } // namespace void SimplifyRegionLitePass::runOnOperation() { auto op = getOperation(); auto regions = op->getRegions(); mlir::RewritePatternSet patterns(op.getContext()); - DummyRewriter rewriter(op.getContext()); if (regions.empty()) return; + mlir::PatternRewriter rewriter(op.getContext()); (void)mlir::eraseUnreachableBlocks(rewriter, regions); (void)mlir::runRegionDCE(rewriter, regions); } diff --git a/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp b/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp index 639e0feabc9bd..f0c1f4485b054 100644 --- a/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp +++ b/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp @@ -70,12 +70,7 @@ static FailureOr tryApply(Operation *operation, Args &&...args) { PatternTy pattern(operation->getContext(), std::forward(args)...); // We want to discourage direct use of PatternRewriter in APIs but In this // very specific case, an IRRewriter is not enough. - struct TrivialPatternRewriter : public PatternRewriter { - public: - explicit TrivialPatternRewriter(MLIRContext *context) - : PatternRewriter(context) {} - }; - TrivialPatternRewriter rewriter(operation->getContext()); + PatternRewriter rewriter(operation->getContext()); rewriter.setInsertionPoint(operation); auto result = pattern.returningMatchAndRewrite(op, rewriter); if (failed(result)) diff --git a/mlir/lib/Dialect/Transform/PDLExtension/PDLExtensionOps.cpp b/mlir/lib/Dialect/Transform/PDLExtension/PDLExtensionOps.cpp index 41955c8a278f2..3ced1a6582ce3 100644 --- a/mlir/lib/Dialect/Transform/PDLExtension/PDLExtensionOps.cpp +++ b/mlir/lib/Dialect/Transform/PDLExtension/PDLExtensionOps.cpp @@ -100,12 +100,7 @@ LogicalResult PatternApplicatorExtension::findAllMatches( PatternApplicator applicator(it->second); // We want to discourage direct use of PatternRewriter in APIs but In this // very specific case, an IRRewriter is not enough. - struct TrivialPatternRewriter : public PatternRewriter { - public: - explicit TrivialPatternRewriter(MLIRContext *context) - : PatternRewriter(context) {} - }; - TrivialPatternRewriter rewriter(root->getContext()); + PatternRewriter rewriter(root->getContext()); applicator.applyDefaultCostModel(); root->walk([&](Operation *op) { if (succeeded(applicator.matchAndRewrite(op, rewriter))) diff --git a/mlir/unittests/Rewrite/PatternBenefit.cpp b/mlir/unittests/Rewrite/PatternBenefit.cpp index 65ea4ee6683db..e4363f9f4b8bb 100644 --- a/mlir/unittests/Rewrite/PatternBenefit.cpp +++ b/mlir/unittests/Rewrite/PatternBenefit.cpp @@ -66,12 +66,7 @@ TEST(PatternBenefitTest, BenefitOrder) { PatternApplicator pa(frozenPatterns); pa.applyDefaultCostModel(); - class MyPatternRewriter : public PatternRewriter { - public: - MyPatternRewriter(MLIRContext *ctx) : PatternRewriter(ctx) {} - }; - - MyPatternRewriter rewriter(&context); + PatternRewriter rewriter(&context); (void)pa.matchAndRewrite(*module, rewriter); EXPECT_TRUE(called1);